Bug 221105

Summary: Extract color model and transfer functions into their own files
Product: WebKit Reporter: Sam Weinig <sam>
Component: New BugsAssignee: Sam Weinig <sam>
Status: RESOLVED FIXED    
Severity: Normal CC: annulen, darin, ews-watchlist, gyuyoung.kim, ryuan.choi, sergio, simon.fraser, thorton, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
ews-feeder: commit-queue-
Patch
none
Patch
none
Patch
ews-feeder: commit-queue-
Patch none

Sam Weinig
Reported 2021-01-28 14:30:24 PST
Extract color model and transfer functions into their own files
Attachments
Patch (30.20 KB, patch)
2021-01-28 14:32 PST, Sam Weinig 		no flags
DetailsFormatted DiffDiff
Patch (31.47 KB, patch)
2021-01-28 14:34 PST, Sam Weinig 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (31.55 KB, patch)
2021-01-28 16:16 PST, Sam Weinig 		no flags
DetailsFormatted DiffDiff
Patch (31.55 KB, patch)
2021-01-28 16:28 PST, Sam Weinig 		no flags
DetailsFormatted DiffDiff
Patch (31.82 KB, patch)
2021-01-28 19:00 PST, Sam Weinig 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (28.66 KB, patch)
2021-01-29 08:59 PST, Sam Weinig 		no flags
DetailsFormatted DiffDiff
Show Obsolete (5) View All Add attachment proposed patch, testcase, etc.
Sam Weinig
Comment 1 2021-01-28 14:32:48 PST Comment hidden (obsolete)
Sam Weinig
Comment 2 2021-01-28 14:34:46 PST Comment hidden (obsolete)
Sam Weinig
Comment 3 2021-01-28 16:16:38 PST Comment hidden (obsolete)
Sam Weinig
Comment 4 2021-01-28 16:28:12 PST Comment hidden (obsolete)
Sam Weinig
Comment 5 2021-01-28 19:00:27 PST
Created attachment 418693 [details] Patch
Simon Fraser (smfr)
Comment 6 2021-01-28 20:14:35 PST
Comment on attachment 418693 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=418693&action=review > Source/WebCore/ChangeLog:11 > + Things are getting a bit cramped in ColorTypes.h and ColorConversions. > + This extracts the color models into ColorModel.h and gamma transfer > + functions into ColorTransferFunction.h and generalized the transfer > + functions a bit to reduce the code size. Should the new filenames be pluralized?
Sam Weinig
Comment 7 2021-01-29 08:57:48 PST
(In reply to Simon Fraser (smfr) from comment #6) > Comment on attachment 418693 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=418693&action=review > > > Source/WebCore/ChangeLog:11 > > + Things are getting a bit cramped in ColorTypes.h and ColorConversions. > > + This extracts the color models into ColorModel.h and gamma transfer > > + functions into ColorTransferFunction.h and generalized the transfer > > + functions a bit to reduce the code size. > > Should the new filenames be pluralized? Yeah, that would be more consistent.
Sam Weinig
Comment 8 2021-01-29 08:59:30 PST
Created attachment 418732 [details] Patch
EWS
Comment 9 2021-01-29 10:48:20 PST
Committed r272066: <https://trac.webkit.org/changeset/272066> All reviewed patches have been landed. Closing bug and clearing flags on attachment 418732 [details].
Radar WebKit Bug Importer
Comment 10 2021-01-29 10:49:14 PST
<rdar://problem/73761809>
Note You need to log in before you can comment on or make changes to this bug.