Summary: | Extract color model and transfer functions into their own files | ||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Sam Weinig <sam> | ||||||||||||||
Component: | New Bugs | Assignee: | Sam Weinig <sam> | ||||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||||
Severity: | Normal | CC: | annulen, darin, ews-watchlist, gyuyoung.kim, ryuan.choi, sergio, simon.fraser, thorton, webkit-bug-importer | ||||||||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||||||||
Version: | WebKit Nightly Build | ||||||||||||||||
Hardware: | Unspecified | ||||||||||||||||
OS: | Unspecified | ||||||||||||||||
Attachments: |
|
Description
Sam Weinig
2021-01-28 14:30:24 PST
Created attachment 418670 [details]
Patch
Created attachment 418671 [details]
Patch
Created attachment 418678 [details]
Patch
Created attachment 418679 [details]
Patch
Created attachment 418693 [details]
Patch
Comment on attachment 418693 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=418693&action=review > Source/WebCore/ChangeLog:11 > + Things are getting a bit cramped in ColorTypes.h and ColorConversions. > + This extracts the color models into ColorModel.h and gamma transfer > + functions into ColorTransferFunction.h and generalized the transfer > + functions a bit to reduce the code size. Should the new filenames be pluralized? (In reply to Simon Fraser (smfr) from comment #6) > Comment on attachment 418693 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=418693&action=review > > > Source/WebCore/ChangeLog:11 > > + Things are getting a bit cramped in ColorTypes.h and ColorConversions. > > + This extracts the color models into ColorModel.h and gamma transfer > > + functions into ColorTransferFunction.h and generalized the transfer > > + functions a bit to reduce the code size. > > Should the new filenames be pluralized? Yeah, that would be more consistent. Created attachment 418732 [details]
Patch
Committed r272066: <https://trac.webkit.org/changeset/272066> All reviewed patches have been landed. Closing bug and clearing flags on attachment 418732 [details]. |