Bug 221105

Summary: Extract color model and transfer functions into their own files
Product: WebKit Reporter: Sam Weinig <sam>
Component: New BugsAssignee: Sam Weinig <sam>
Status: RESOLVED FIXED    
Severity: Normal CC: annulen, darin, ews-watchlist, gyuyoung.kim, ryuan.choi, sergio, simon.fraser, thorton, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
ews-feeder: commit-queue-
Patch
none
Patch
none
Patch
ews-feeder: commit-queue-
Patch none

Description Sam Weinig 2021-01-28 14:30:24 PST
Extract color model and transfer functions into their own files
Comment 1 Sam Weinig 2021-01-28 14:32:48 PST Comment hidden (obsolete)
Comment 2 Sam Weinig 2021-01-28 14:34:46 PST Comment hidden (obsolete)
Comment 3 Sam Weinig 2021-01-28 16:16:38 PST Comment hidden (obsolete)
Comment 4 Sam Weinig 2021-01-28 16:28:12 PST Comment hidden (obsolete)
Comment 5 Sam Weinig 2021-01-28 19:00:27 PST
Created attachment 418693 [details]
Patch
Comment 6 Simon Fraser (smfr) 2021-01-28 20:14:35 PST
Comment on attachment 418693 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=418693&action=review

> Source/WebCore/ChangeLog:11
> +        Things are getting a bit cramped in ColorTypes.h and ColorConversions.
> +        This extracts the color models into ColorModel.h and gamma transfer 
> +        functions into ColorTransferFunction.h and generalized the transfer
> +        functions a bit to reduce the code size.

Should the new filenames be pluralized?
Comment 7 Sam Weinig 2021-01-29 08:57:48 PST
(In reply to Simon Fraser (smfr) from comment #6)
> Comment on attachment 418693 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=418693&action=review
> 
> > Source/WebCore/ChangeLog:11
> > +        Things are getting a bit cramped in ColorTypes.h and ColorConversions.
> > +        This extracts the color models into ColorModel.h and gamma transfer 
> > +        functions into ColorTransferFunction.h and generalized the transfer
> > +        functions a bit to reduce the code size.
> 
> Should the new filenames be pluralized?

Yeah, that would be more consistent.
Comment 8 Sam Weinig 2021-01-29 08:59:30 PST
Created attachment 418732 [details]
Patch
Comment 9 EWS 2021-01-29 10:48:20 PST
Committed r272066: <https://trac.webkit.org/changeset/272066>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 418732 [details].
Comment 10 Radar WebKit Bug Importer 2021-01-29 10:49:14 PST
<rdar://problem/73761809>