Bug 221056

Summary: [macOS] Remove reference to deprecated SubmitDiagInfo.domains path
Product: WebKit Reporter: Brent Fulgham <bfulgham>
Component: WebKit Misc.Assignee: Brent Fulgham <bfulgham>
Status: RESOLVED FIXED    
Severity: Normal CC: pvollan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Brent Fulgham
Reported 2021-01-27 12:09:26 PST
We don't need access to this path, so let's remove it from our sandbox.
Attachments
Patch (4.49 KB, patch)
2021-01-27 12:12 PST, Brent Fulgham 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Brent Fulgham
Comment 1 2021-01-27 12:11:43 PST
<rdar://problem/73474697>
Brent Fulgham
Comment 2 2021-01-27 12:12:14 PST
Created attachment 418573 [details] Patch
Per Arne Vollan
Comment 3 2021-01-27 12:13:17 PST
Comment on attachment 418573 [details] Patch R=me.
Alexey Proskuryakov
Comment 4 2021-01-27 14:50:59 PST
Comment on attachment 418573 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=418573&action=review > Source/WebKit/ChangeLog:9 > + macOS does not use SubmitDiagInfo.domains anymore, and even when it did it failed safely. Does this include all supported macOS versions, or only the latest?
Brent Fulgham
Comment 5 2021-01-28 09:24:50 PST
(In reply to Alexey Proskuryakov from comment #4) > Comment on attachment 418573 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=418573&action=review > > > Source/WebKit/ChangeLog:9 > > + macOS does not use SubmitDiagInfo.domains anymore, and even when it did it failed safely. > > Does this include all supported macOS versions, or only the latest? All supported OS versions.
Brent Fulgham
Comment 6 2021-01-28 09:25:17 PST
(In reply to Brent Fulgham from comment #5) > (In reply to Alexey Proskuryakov from comment #4) > > Comment on attachment 418573 [details] > > Patch > > > > View in context: > > https://bugs.webkit.org/attachment.cgi?id=418573&action=review > > > > > Source/WebKit/ChangeLog:9 > > > + macOS does not use SubmitDiagInfo.domains anymore, and even when it did it failed safely. > > > > Does this include all supported macOS versions, or only the latest? > > All supported OS versions. (According to the responsible team using this path).
EWS
Comment 7 2021-01-28 09:28:36 PST
Committed r272016: <https://trac.webkit.org/changeset/272016> All reviewed patches have been landed. Closing bug and clearing flags on attachment 418573 [details].
Note You need to log in before you can comment on or make changes to this bug.