Bug 221048

Summary: [GPUProcess] Move ownership of RingBuffer backing used by RemoteAudioSourceProviderManager::RemoteAudio to WebProcess
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: WebKit2Assignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, cmarcelo, eric.carlson, ews-watchlist, ggaren, glenn, jer.noble, peng.liu6, philipj, sergio, simon.fraser, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=241014
Attachments:
Description Flags
Patch
ews-feeder: commit-queue-
Patch
ews-feeder: commit-queue-
Patch none

Chris Dumez
Reported 2021-01-27 10:27:39 PST
Move ownership of RingBuffer backing used by RemoteAudioSourceProviderManager::RemoteAudio from the GPUProcess to WebProcess, for jetsam purposes. This moves half a megabyte of memory from the GPUProcess to the WebProcess on https://foobar404.github.io/Wave.js.
Attachments
Patch (10.33 KB, patch)
2021-01-27 13:28 PST, Chris Dumez 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (10.77 KB, patch)
2021-01-27 14:06 PST, Chris Dumez 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (10.80 KB, patch)
2021-01-27 14:29 PST, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2021-01-27 13:28:07 PST
Created attachment 418578 [details] Patch
Chris Dumez
Comment 2 2021-01-27 14:06:57 PST
Created attachment 418580 [details] Patch
Chris Dumez
Comment 3 2021-01-27 14:29:37 PST
Created attachment 418582 [details] Patch
Geoffrey Garen
Comment 4 2021-01-27 15:05:55 PST
Comment on attachment 418582 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=418582&action=review r=me > Source/WebKit/Platform/cocoa/SharedMemoryCocoa.cpp:63 > + case MemoryLedger::Neural: > + return VM_LEDGER_TAG_NEURAL; Mmmmmm.... Johnny Mnemonic.
EWS
Comment 5 2021-01-27 15:58:08 PST
Committed r271989: <https://trac.webkit.org/changeset/271989> All reviewed patches have been landed. Closing bug and clearing flags on attachment 418582 [details].
Radar WebKit Bug Importer
Comment 6 2021-01-27 15:59:15 PST
<rdar://problem/73684206>
Note You need to log in before you can comment on or make changes to this bug.