Bug 221045

Summary: [macOS] WebContent sandbox regex incorrect
Product: WebKit Reporter: Per Arne Vollan <pvollan>
Component: WebKit Misc.Assignee: Per Arne Vollan <pvollan>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Description Per Arne Vollan 2021-01-27 08:57:20 PST 
When the regex is intended to match the character '.', the pattern '\.' should be used.
Comment 1 Per Arne Vollan 2021-01-27 08:57:43 PST 
<rdar://problem/73473985>
Comment 2 Per Arne Vollan 2021-01-27 08:58:53 PST 
Created attachment 418551 [details]
Patch
Comment 3 Brent Fulgham 2021-01-27 09:47:26 PST 
Comment on attachment 418551 [details]
Patch

r=me. I'm embarrassed because I think I introduced those years ago. We might also consider switching away from regex, as the Sandbox team told us there are performance costs to using them.
Comment 4 Per Arne Vollan 2021-01-27 10:03:46 PST 
(In reply to Brent Fulgham from comment #3)
> Comment on attachment 418551 [details]
> Patch
> 
> r=me. I'm embarrassed because I think I introduced those years ago. We might
> also consider switching away from regex, as the Sandbox team told us there
> are performance costs to using them.

These are easily mixed up in regex :) Yes, we should also look into switching away from regex.

Thanks for reviewing!
Comment 5 EWS 2021-01-27 10:07:22 PST 
Committed r271963: <https://trac.webkit.org/changeset/271963>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 418551 [details].