Bug 221026

Summary: Use SFTranscription instead of SFTranscriptionSegment for SpeechRecognitionAlternative
Product: WebKit Reporter: Sihui Liu <sihui_liu>
Component: New BugsAssignee: Sihui Liu <sihui_liu>
Status: RESOLVED FIXED    
Severity: Normal CC: webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Description Sihui Liu 2021-01-27 00:44:03 PST
...
Comment 1 Sihui Liu 2021-01-27 00:56:52 PST
Created attachment 418512 [details]
Patch
Comment 2 youenn fablet 2021-01-27 01:10:55 PST
Comment on attachment 418512 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=418512&action=review

> Source/WebCore/ChangeLog:8
> +        So SpeechRecognitionAlternative contains a sentence instead of a word, which matches Blink's behavior.

Does this work well with websites doing word concatenation with space themselves?
Comment 3 Sihui Liu 2021-01-27 08:45:46 PST
(In reply to youenn fablet from comment #2)
> Comment on attachment 418512 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=418512&action=review
> 
> > Source/WebCore/ChangeLog:8
> > +        So SpeechRecognitionAlternative contains a sentence instead of a word, which matches Blink's behavior.
> 
> Does this work well with websites doing word concatenation with space
> themselves?

Yes, because in this case they just insert spaces between sentences while concatenating them.
Comment 4 EWS 2021-01-27 09:39:28 PST
Committed r271958: <https://trac.webkit.org/changeset/271958>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 418512 [details].
Comment 5 Radar WebKit Bug Importer 2021-01-27 09:40:15 PST
<rdar://problem/73665700>