Bug 221000

Summary: [macOS] Remove CFPBS access in the WebContent process
Product: WebKit Reporter: Per Arne Vollan <pvollan>
Component: WebKit Misc.Assignee: Per Arne Vollan <pvollan>
Status: RESOLVED FIXED    
Severity: Normal CC: amruthraj, bfulgham, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
bfulgham: review+, ews-feeder: commit-queue-
Patch none

Description Per Arne Vollan 2021-01-26 11:40:39 PST
Remove CFPBS access in the WebContent process on macOS, since there are no reports of this being used.
Comment 1 Per Arne Vollan 2021-01-26 11:41:00 PST
<rdar://problem/70501475>
Comment 2 Per Arne Vollan 2021-01-26 11:42:56 PST
Created attachment 418453 [details]
Patch
Comment 3 Brent Fulgham 2021-01-27 09:39:48 PST
Comment on attachment 418453 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=418453&action=review

> Source/WebKit/WebProcess/com.apple.WebProcess.sb.in:-1238
> -    (ipc-posix-name-regex #"^CFPBS:")) ; <rdar://problem/13757475>

To be safe, should we just move the version check so we leave this on for older OS's? We don't have telemetry for old systems.
Comment 4 Per Arne Vollan 2021-01-27 09:58:52 PST
Created attachment 418556 [details]
Patch
Comment 5 Brent Fulgham 2021-01-27 09:59:43 PST
Comment on attachment 418556 [details]
Patch

Excellent! r=me
Comment 6 Per Arne Vollan 2021-01-27 10:06:57 PST
Comment on attachment 418556 [details]
Patch

Thanks for reviewing!
Comment 7 EWS 2021-01-27 10:07:41 PST
Tools/Scripts/svn-apply failed to apply attachment 418556 [details] to trunk.
Please resolve the conflicts and upload a new patch.
Comment 8 Per Arne Vollan 2021-01-27 10:16:25 PST
Created attachment 418557 [details]
Patch
Comment 9 EWS 2021-01-27 10:45:51 PST
Committed r271966: <https://trac.webkit.org/changeset/271966>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 418557 [details].