Summary: | REGRESSION(r270637) Filtering does not work in Styles sidebar panel | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Razvan Caliman <rcaliman> | ||||||
Component: | Web Inspector | Assignee: | Nobody <webkit-unassigned> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | bburg, ews-watchlist, hi, inspector-bugzilla-changes, nvasilyev, webkit-bug-importer | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | All | ||||||||
OS: | All | ||||||||
Attachments: |
|
Description
Razvan Caliman
2021-01-26 10:57:19 PST
[Error] TypeError: super.filterDidChange is not a function. (In 'super.filterDidChange(filterBar)', 'super.filterDidChange' is undefined) filterDidChange (SpreadsheetRulesStyleDetailsPanel.js:323) _filterDidChange (GeneralStyleDetailsSidebarPanel.js:431) dispatch (Object.js:130) dispatchEventToListeners (Object.js:138) _handleFilterChanged (FilterBar.js:198) _handleFilterChanged Created attachment 418448 [details]
Patch
Comment on attachment 418448 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=418448&action=review r=me with a recommended alternative > Source/WebInspectorUI/ChangeLog:9 > + Reverting removal of abstract method used by SpreadsheetRulesStyleDetailsPanel. I think we should just remove the `super.filterDidChange(filterBar);` call in `ComputedStyleDetailsPanel.js`. `WI.GeneralStyleDetailsSidebarPanel.prototype.initialLayout` checks for `typeof this._panel.filterDidChange === "function"`, so it may be better to remove it from the superclass in case we add new subclasses that don't actually override it. Created attachment 418454 [details]
Patch
Comment on attachment 418448 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=418448&action=review >> Source/WebInspectorUI/ChangeLog:9 >> + Reverting removal of abstract method used by SpreadsheetRulesStyleDetailsPanel. > > I think we should just remove the `super.filterDidChange(filterBar);` call in `ComputedStyleDetailsPanel.js`. `WI.GeneralStyleDetailsSidebarPanel.prototype.initialLayout` checks for `typeof this._panel.filterDidChange === "function"`, so it may be better to remove it from the superclass in case we add new subclasses that don't actually override it. Sounds good. Done! Comment on attachment 418454 [details]
Patch
r=me
Setting cq+ Committed r271927: <https://trac.webkit.org/changeset/271927> All reviewed patches have been landed. Closing bug and clearing flags on attachment 418454 [details]. |