Bug 220977

Summary: Support aspect-ratio on grid items
Product: WebKit Reporter: Rob Buis <rbuis>
Component: CSSAssignee: Rob Buis <rbuis>
Status: RESOLVED FIXED    
Severity: Normal CC: changseok, esprehn+autocc, ews-watchlist, glenn, jfernandez, kondapallykalyan, pdr, rego, svillar, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 47738    
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch none

Rob Buis
Reported 2021-01-26 06:04:24 PST
Support aspect-ratio on grid items.
Attachments
Patch (4.25 KB, patch)
2021-01-26 06:08 PST, Rob Buis 		no flags
DetailsFormatted DiffDiff
Patch (4.24 KB, patch)
2021-01-26 22:07 PST, Rob Buis 		no flags
DetailsFormatted DiffDiff
Patch (6.37 KB, patch)
2021-01-27 07:35 PST, Rob Buis 		no flags
DetailsFormatted DiffDiff
Patch (7.72 KB, patch)
2021-01-29 01:39 PST, Rob Buis 		no flags
DetailsFormatted DiffDiff
Patch (7.72 KB, patch)
2021-01-29 03:18 PST, Rob Buis 		no flags
DetailsFormatted DiffDiff
Patch (7.52 KB, patch)
2021-01-29 04:33 PST, Rob Buis 		no flags
DetailsFormatted DiffDiff
Patch (6.54 KB, patch)
2021-02-02 01:21 PST, Rob Buis 		no flags
DetailsFormatted DiffDiff
Patch (6.51 KB, patch)
2021-02-03 01:44 PST, Rob Buis 		no flags
DetailsFormatted DiffDiff
Patch (6.55 KB, patch)
2021-02-03 04:14 PST, Rob Buis 		no flags
DetailsFormatted DiffDiff
Show Obsolete (8) View All Add attachment proposed patch, testcase, etc.
Rob Buis
Comment 1 2021-01-26 06:08:01 PST
Created attachment 418408 [details] Patch
Rob Buis
Comment 2 2021-01-26 22:07:16 PST
Created attachment 418510 [details] Patch
Rob Buis
Comment 3 2021-01-27 07:35:59 PST
Created attachment 418547 [details] Patch
Rob Buis
Comment 4 2021-01-29 01:39:32 PST
Created attachment 418712 [details] Patch
Rob Buis
Comment 5 2021-01-29 03:18:31 PST
Created attachment 418715 [details] Patch
Rob Buis
Comment 6 2021-01-29 04:33:51 PST
Created attachment 418717 [details] Patch
Rob Buis
Comment 7 2021-01-29 08:21:05 PST
Comment on attachment 418717 [details] Patch Clearing review flag for now since fixing https://bugs.webkit.org/show_bug.cgi?id=204578 first would make this patch smaller and easier to review.
Rob Buis
Comment 8 2021-02-02 01:21:36 PST
Created attachment 418972 [details] Patch
Radar WebKit Bug Importer
Comment 9 2021-02-02 06:05:16 PST
<rdar://problem/73877205>
Rob Buis
Comment 10 2021-02-03 01:44:57 PST
Created attachment 419114 [details] Patch
Javier Fernandez
Comment 11 2021-02-03 03:22:39 PST
Comment on attachment 419114 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=419114&action=review r=me > Source/WebCore/rendering/RenderGrid.cpp:1866 > + // A non-auto inline size means the same for block size Nit: no need to wrap comments here > Source/WebCore/rendering/RenderGrid.cpp:1883 > + // A non-auto block size means the same for inline size Ditto
Rob Buis
Comment 12 2021-02-03 04:14:07 PST
Created attachment 419121 [details] Patch
EWS
Comment 13 2021-02-03 05:05:58 PST
Committed r272307: <https://trac.webkit.org/changeset/272307> All reviewed patches have been landed. Closing bug and clearing flags on attachment 419121 [details].
Note You need to log in before you can comment on or make changes to this bug.