Bug 220973

Summary: [MacOS] Enable NSURLSession WebSocket code path in WebKitTestRunner
Product: WebKit Reporter: youenn fablet <youennf>
Component: Page LoadingAssignee: youenn fablet <youennf>
Status: RESOLVED FIXED    
Severity: Normal CC: beidson, benjamin, cdumez, cmarcelo, commit-queue, darin, ews-watchlist, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Local Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 221040    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch for landing
none
Rebasing none

youenn fablet
Reported 2021-01-26 05:41:46 PST
[BigSur] Enable NSURLSession WebSocket code path in WebKitTestRunner
Attachments
Patch (58.92 KB, patch)
2021-01-26 06:04 PST, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch for landing (59.06 KB, patch)
2021-01-27 00:57 PST, youenn fablet 		no flags
DetailsFormatted DiffDiff
Rebasing (4.87 KB, patch)
2021-03-31 08:46 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
youenn fablet
Comment 1 2021-01-26 06:04:01 PST
Created attachment 418407 [details] Patch
Darin Adler
Comment 2 2021-01-26 09:43:29 PST
Comment on attachment 418407 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=418407&action=review > Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.mm:1038 > + // FIXME: reenable below ASSERT once rdar://problem/72383646 is fixed. Better grammar would be: // FIXME: We can re-enable ASSERT below once NSURLSession bug rdar://problem/72383646 is fixed. Ideally the comment makes it clear or at least implies that it’s not urgent to re-enable the assertion and there’s no detectable symptom of the bug.
youenn fablet
Comment 3 2021-01-27 00:57:05 PST
Created attachment 418513 [details] Patch for landing
youenn fablet
Comment 4 2021-01-27 02:40:13 PST
I can see flakiness in some tests when running them several times. I believe this is due to rdar://problem/73613227. Let's see whether these potential flakinesses will disturb the bots.
EWS
Comment 5 2021-01-27 02:57:27 PST
Committed r271940: <https://trac.webkit.org/changeset/271940> All reviewed patches have been landed. Closing bug and clearing flags on attachment 418513 [details].
Radar WebKit Bug Importer
Comment 6 2021-01-27 02:58:14 PST
<rdar://problem/73655870>
WebKit Commit Bot
Comment 7 2021-01-27 06:18:24 PST
Re-opened since this is blocked by bug 221040
youenn fablet
Comment 8 2021-01-27 06:18:49 PST
Some additional test failures found in the bot: https://build.webkit.org/results/Apple-BigSur-Release-WK2-Tests/r271940%20(1203)/results.html
youenn fablet
Comment 9 2021-03-31 08:46:06 PDT
Created attachment 424773 [details] Rebasing
youenn fablet
Comment 10 2021-03-31 08:46:43 PDT
Rebased patch and bumped support to after BigSur and iOS 15. This removes the need to update test expectations.
EWS
Comment 11 2021-04-02 03:44:24 PDT
Committed r275415: <https://commits.webkit.org/r275415> All reviewed patches have been landed. Closing bug and clearing flags on attachment 424773 [details].
Note You need to log in before you can comment on or make changes to this bug.