Bug 220956 – Crash when remote inspecting in debug builds

• Component: Web Inspector
• Status: RESOLVED FIXED

[Simon Fraser (smfr)]

Crash when remote inspecting in debug builds

[Simon Fraser (smfr)]

Created attachment 418347 [details]
Patch

[Devin Rousso]

Comment on attachment 418347 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=418347&action=review

> Source/JavaScriptCore/inspector/remote/cocoa/RemoteConnectionToTargetCocoa.mm:215
> +    dispatchAsyncOnTarget([this, message = [[message copy] autorelease], strongThis = makeRef(*this)]() {

I believe that `message` isn't ever used after calling `sendMessageToTarget`.  Can we avoid creating a copy?

[Simon Fraser (smfr)]

Created attachment 418355 [details]
Patch

[Devin Rousso]

Comment on attachment 418355 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=418355&action=review

r=me, nice fix!

> Source/JavaScriptCore/inspector/remote/cocoa/RemoteConnectionToTargetCocoa.mm:207
> +            if (targetIdentifier)

Why was this added?  `RemoteInspector::updateTargetListing` should be able to handle `0`.

[EWS]

Committed r271876: <https://trac.webkit.org/changeset/271876>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 418355 [details].

[Radar WebKit Bug Importer]

<rdar://problem/73602775>

[Blaze Burg]

Comment on attachment 418355 [details]
Patch

Thanks for digging on this, Simon!

[Joseph Pecoraro]

Do we actually know why BlockPtr doesn't work well with ARC?

[Simon Fraser (smfr)]

It works fine with ARC, but not when the linker links an ARC-compiled function into a caller that is not complied with ARC.