Bug 220945

Summary: Remove MediaSourcePrivateClient::monitorSourceBuffers()
Product: WebKit Reporter: Peng Liu <peng.liu6>
Component: MediaAssignee: Peng Liu <peng.liu6>
Status: RESOLVED FIXED    
Severity: Normal CC: aboya, calvaris, cdumez, changseok, eric.carlson, esprehn+autocc, ews-watchlist, glenn, gyuyoung.kim, jer.noble, philipj, pnormand, sergio, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Peng Liu
Reported 2021-01-25 13:48:09 PST
Remove MediaSourcePrivateClient::monitorSourceBuffers()
Attachments
Patch (6.80 KB, patch)
2021-01-25 13:55 PST, Peng Liu 		no flags
DetailsFormatted DiffDiff
Patch (6.95 KB, patch)
2021-01-25 14:23 PST, Peng Liu 		no flags
DetailsFormatted DiffDiff
Patch (7.00 KB, patch)
2021-01-25 14:40 PST, Peng Liu 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Peng Liu
Comment 1 2021-01-25 13:55:18 PST
Created attachment 418332 [details] Patch
Peng Liu
Comment 2 2021-01-25 14:23:03 PST
Created attachment 418337 [details] Patch
Peng Liu
Comment 3 2021-01-25 14:40:52 PST
Created attachment 418339 [details] Patch
Radar WebKit Bug Importer
Comment 4 2021-02-01 13:49:43 PST
<rdar://problem/73844547>
youenn fablet
Comment 5 2021-02-05 06:05:58 PST
Comment on attachment 418339 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=418339&action=review > Source/WebCore/ChangeLog:10 > + related to seeking. Why keeping it for GStreamer, I do not see GStreamer code related to it?
Philippe Normand
Comment 6 2021-02-08 01:13:08 PST
Comment on attachment 418339 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=418339&action=review >> Source/WebCore/ChangeLog:10 >> + related to seeking. > > Why keeping it for GStreamer, I do not see GStreamer code related to it? https://github.com/WebKit/WebKit/blob/main/Source/WebCore/platform/graphics/gstreamer/mse/MediaPlayerPrivateGStreamerMSE.cpp#L329
Alicia Boya García
Comment 7 2021-02-08 01:48:05 PST
I built this on GTK and didn't see any new failures in GTK Debug LayoutTests. I don't see a problem myself.
youenn fablet
Comment 8 2021-02-08 02:47:04 PST
(In reply to Philippe Normand from comment #6) > Comment on attachment 418339 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=418339&action=review > > >> Source/WebCore/ChangeLog:10 > >> + related to seeking. > > > > Why keeping it for GStreamer, I do not see GStreamer code related to it? > > https://github.com/WebKit/WebKit/blob/main/Source/WebCore/platform/graphics/ > gstreamer/mse/MediaPlayerPrivateGStreamerMSE.cpp#L329 Given monitorSourceBuffers implementation does not seem to do anything, can MediaPlayerPrivateGStreamerMSE.cpp be updated to remove the call to monitorSourceBuffers?
Philippe Normand
Comment 9 2021-02-08 05:22:29 PST
I guess we're looking at different code-bases then :) MediaSource::monitorSourceBuffers() does quite a few things, including calling completeSeek().
Peng Liu
Comment 10 2021-02-10 15:45:26 PST
Let's only remove this function for apple's ports.
EWS
Comment 11 2021-02-10 16:07:33 PST
Committed r272696: <https://commits.webkit.org/r272696> All reviewed patches have been landed. Closing bug and clearing flags on attachment 418339 [details].
Note You need to log in before you can comment on or make changes to this bug.