Bug 220939

Summary: Rename MediaElementSession::playbackPermitted() to MediaElementSession::playbackStateChangePermitted()
Product: WebKit Reporter: Peng Liu <peng.liu6>
Component: MediaAssignee: Peng Liu <peng.liu6>
Status: RESOLVED FIXED    
Severity: Normal CC: calvaris, cdumez, changseok, eric.carlson, esprehn+autocc, ews-watchlist, glenn, gyuyoung.kim, jer.noble, philipj, sergio, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=220887
Attachments:
Description Flags
Patch
youennf: review+, ews-feeder: commit-queue-
Patch for landing none

Peng Liu
Reported 2021-01-25 11:49:14 PST
MediaElementSession::playbackPermitted() is used in many places to check whether a playback state change is allowed or not. We had better add a parameter to indicate the state change request. Otherwise, it may return false when it is expected to return true.
Attachments
Patch (11.26 KB, patch)
2021-03-29 17:01 PDT, Peng Liu 		youennf: review+
ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch for landing (11.37 KB, patch)
2021-03-30 10:24 PDT, Peng Liu 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2021-02-01 11:51:33 PST
<rdar://problem/73839280>
Peng Liu
Comment 2 2021-03-29 17:01:52 PDT
Created attachment 424602 [details] Patch
Eric Carlson
Comment 3 2021-03-30 07:04:11 PDT
Comment on attachment 424602 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=424602&action=review > Source/WebCore/html/MediaElementSession.cpp:286 > ALWAYS_LOG(LOGIDENTIFIER, "Returning FALSE because element is suspended"); Now that we always pass the new state, it would be nice to include that in the logging so we know what state change was allowed/denied.
Peng Liu
Comment 4 2021-03-30 09:42:01 PDT
Comment on attachment 424602 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=424602&action=review >> Source/WebCore/html/MediaElementSession.cpp:286 >> ALWAYS_LOG(LOGIDENTIFIER, "Returning FALSE because element is suspended"); > > Now that we always pass the new state, it would be nice to include that in the logging so we know what state change was allowed/denied. Good idea! Will add that.
Peng Liu
Comment 5 2021-03-30 10:24:19 PDT
Created attachment 424656 [details] Patch for landing
EWS
Comment 6 2021-03-30 12:15:02 PDT
Committed r275225: <https://commits.webkit.org/r275225> All reviewed patches have been landed. Closing bug and clearing flags on attachment 424656 [details].
Note You need to log in before you can comment on or make changes to this bug.