Bug 220938

Summary: [GLIB] API tests fail to report harness failures
Product: WebKit Reporter: Lauro Moura <lmoura>
Component: Tools / TestsAssignee: Lauro Moura <lmoura>
Status: RESOLVED FIXED    
Severity: Normal CC: bugs-noreply, cgarcia, mcatanzaro, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=220922
https://bugs.webkit.org/show_bug.cgi?id=220366
https://bugs.webkit.org/show_bug.cgi?id=220863
Attachments:
Description Flags
Patch
none
Patch for landing. none

Lauro Moura
Reported 2021-01-25 11:40:45 PST
The glib API test runner fails to report crashes in the test harness (e.g. the `beforeAll()` family of functions). This hid the issues setting up WebKitTestServer, related to bug220366 and bug220922 (reverted the original Soup commits). Patch almost ready.
Attachments
Patch (2.26 KB, patch)
2021-01-25 20:18 PST, Lauro Moura 		no flags
DetailsFormatted DiffDiff
Patch for landing. (2.30 KB, patch)
2021-01-26 09:17 PST, Lauro Moura 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Lauro Moura
Comment 1 2021-01-25 20:18:57 PST
Created attachment 418366 [details] Patch
Carlos Garcia Campos
Comment 2 2021-01-26 00:42:13 PST
Comment on attachment 418366 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=418366&action=review Good catch, thanks! > Tools/glib/glib_test_runner.py:272 > + if (not self._results) and p.returncode != 0: Do we need the parentheses here? > Tools/glib/glib_test_runner.py:278 > + elif p.returncode != 0 and not need_restart: # Try to read errors from afterAll Don't use else after a return
Lauro Moura
Comment 3 2021-01-26 09:17:37 PST
Created attachment 418430 [details] Patch for landing.
EWS
Comment 4 2021-01-26 13:33:38 PST
Committed r271902: <https://trac.webkit.org/changeset/271902> All reviewed patches have been landed. Closing bug and clearing flags on attachment 418430 [details].
Radar WebKit Bug Importer
Comment 5 2021-01-26 13:34:13 PST
<rdar://problem/73630623>
Note You need to log in before you can comment on or make changes to this bug.