Bug 220933

Summary: [iOS] improve support for sequential scribble interactions that involving different inputs
Product: WebKit Reporter: Devin Rousso <hi>
Component: PlatformAssignee: Devin Rousso <hi>
Status: RESOLVED FIXED    
Severity: Normal CC: hi, thorton, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Devin Rousso
Reported 2021-01-25 10:57:40 PST
.
Attachments
Patch (5.49 KB, patch)
2021-01-25 10:58 PST, Devin Rousso 		no flags
DetailsFormatted DiffDiff
Patch (6.00 KB, patch)
2021-01-25 11:45 PST, Devin Rousso 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Devin Rousso
Comment 1 2021-01-25 10:58:07 PST
<rdar://problem/71911346>
Devin Rousso
Comment 2 2021-01-25 10:58:49 PST
Created attachment 418308 [details] Patch
Tim Horton
Comment 3 2021-01-25 11:39:22 PST
Comment on attachment 418308 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=418308&action=review > Source/WebKit/UIProcess/ios/WKContentViewInteraction.h:399 > + uint64_t _activeTextInteractionCount; That's a lot of active text interactions! > Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:5351 > + --_activeTextInteractionCount; How sure are you this will never underflow? Maybe an assertion at a minimum?
Devin Rousso
Comment 4 2021-01-25 11:42:45 PST
Comment on attachment 418308 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=418308&action=review >> Source/WebKit/UIProcess/ios/WKContentViewInteraction.h:399 >> + uint64_t _activeTextInteractionCount; > > That's a lot of active text interactions! /me attempts to see how many interactions he could have at the same time Aside: I guess I could make it an `NSInteger` instead to match other member variables 🤔 >> Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:5351 >> + --_activeTextInteractionCount; > > How sure are you this will never underflow? Maybe an assertion at a minimum? Good idea.
Devin Rousso
Comment 5 2021-01-25 11:45:34 PST
Created attachment 418316 [details] Patch
EWS
Comment 6 2021-01-25 16:36:37 PST
Committed r271868: <https://trac.webkit.org/changeset/271868> All reviewed patches have been landed. Closing bug and clearing flags on attachment 418316 [details].
Note You need to log in before you can comment on or make changes to this bug.