Bug 220931

Summary: [macOS] Create extension to Metal compiler service based on GPUP flags
Product: WebKit Reporter: Per Arne Vollan <pvollan>
Component: WebKit Misc.Assignee: Per Arne Vollan <pvollan>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
bfulgham: review+, ews-feeder: commit-queue-
Patch
none
Patch
none
Patch none

Description Per Arne Vollan 2021-01-25 09:30:51 PST
Depending on which GPUP settings are enabled, an extension to the Metal compiler service should be created.
Comment 1 Per Arne Vollan 2021-01-25 09:32:36 PST
Created attachment 418300 [details]
Patch
Comment 2 Radar WebKit Bug Importer 2021-01-25 09:33:31 PST
<rdar://problem/73574476>
Comment 3 Per Arne Vollan 2021-01-25 10:26:25 PST
Created attachment 418305 [details]
Patch
Comment 4 Brent Fulgham 2021-01-25 11:46:33 PST
Comment on attachment 418305 [details]
Patch

r=me. Note that MTLCompiler will be needed for DOM rendering, so there will likely be few cases where this is not needed, but good to be able to turn it off when experimenting with DOM rendering.
Comment 5 Per Arne Vollan 2021-01-25 12:29:00 PST
Created attachment 418321 [details]
Patch
Comment 6 Per Arne Vollan 2021-01-25 12:38:40 PST
Created attachment 418323 [details]
Patch
Comment 7 Per Arne Vollan 2021-01-25 13:32:00 PST
Created attachment 418329 [details]
Patch
Comment 8 Per Arne Vollan 2021-01-25 14:07:35 PST
(In reply to Brent Fulgham from comment #4)
> Comment on attachment 418305 [details]
> Patch
> 
> r=me. Note that MTLCompiler will be needed for DOM rendering, so there will
> likely be few cases where this is not needed, but good to be able to turn it
> off when experimenting with DOM rendering.

Sounds good, thanks for reviewing!
Comment 9 EWS 2021-01-25 14:39:42 PST
Committed r271860: <https://trac.webkit.org/changeset/271860>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 418329 [details].