Bug 220931

Summary: [macOS] Create extension to Metal compiler service based on GPUP flags
Product: WebKit Reporter: Per Arne Vollan <pvollan>
Component: WebKit Misc.Assignee: Per Arne Vollan <pvollan>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
bfulgham: review+, ews-feeder: commit-queue-
Patch
none
Patch
none
Patch none

Per Arne Vollan
Reported 2021-01-25 09:30:51 PST
Depending on which GPUP settings are enabled, an extension to the Metal compiler service should be created.
Attachments
Patch (6.41 KB, patch)
2021-01-25 09:32 PST, Per Arne Vollan 		no flags
DetailsFormatted DiffDiff
Patch (7.27 KB, patch)
2021-01-25 10:26 PST, Per Arne Vollan 		bfulgham: review+
ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (8.53 KB, patch)
2021-01-25 12:29 PST, Per Arne Vollan 		no flags
DetailsFormatted DiffDiff
Patch (8.49 KB, patch)
2021-01-25 12:38 PST, Per Arne Vollan 		no flags
DetailsFormatted DiffDiff
Patch (8.52 KB, patch)
2021-01-25 13:32 PST, Per Arne Vollan 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Per Arne Vollan
Comment 1 2021-01-25 09:32:36 PST
Created attachment 418300 [details] Patch
Radar WebKit Bug Importer
Comment 2 2021-01-25 09:33:31 PST
<rdar://problem/73574476>
Per Arne Vollan
Comment 3 2021-01-25 10:26:25 PST
Created attachment 418305 [details] Patch
Brent Fulgham
Comment 4 2021-01-25 11:46:33 PST
Comment on attachment 418305 [details] Patch r=me. Note that MTLCompiler will be needed for DOM rendering, so there will likely be few cases where this is not needed, but good to be able to turn it off when experimenting with DOM rendering.
Per Arne Vollan
Comment 5 2021-01-25 12:29:00 PST
Created attachment 418321 [details] Patch
Per Arne Vollan
Comment 6 2021-01-25 12:38:40 PST
Created attachment 418323 [details] Patch
Per Arne Vollan
Comment 7 2021-01-25 13:32:00 PST
Created attachment 418329 [details] Patch
Per Arne Vollan
Comment 8 2021-01-25 14:07:35 PST
(In reply to Brent Fulgham from comment #4) > Comment on attachment 418305 [details] > Patch > > r=me. Note that MTLCompiler will be needed for DOM rendering, so there will > likely be few cases where this is not needed, but good to be able to turn it > off when experimenting with DOM rendering. Sounds good, thanks for reviewing!
EWS
Comment 9 2021-01-25 14:39:42 PST
Committed r271860: <https://trac.webkit.org/changeset/271860> All reviewed patches have been landed. Closing bug and clearing flags on attachment 418329 [details].
Note You need to log in before you can comment on or make changes to this bug.