Summary: | [iOS] Obscured elements should not be focusable using the accessory bar | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Aditya Keerthi <akeerthi> | ||||||
Component: | Forms | Assignee: | Aditya Keerthi <akeerthi> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | cdumez, changseok, esprehn+autocc, ews-watchlist, glenn, kondapallykalyan, pdr, thorton, webkit-bug-importer, wenson_hsieh | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | Other | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Aditya Keerthi
2021-01-25 09:25:02 PST
Created attachment 418301 [details]
Patch
Comment on attachment 418301 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=418301&action=review > Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm:2556 > +static inline bool isObscuredElement(Element& element) Why `IgnoreClipping`? Wouldn't you want to take clipping into account to know if you can see the thing? Created attachment 418320 [details]
Patch for landing
(In reply to Tim Horton from comment #3) > Comment on attachment 418301 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=418301&action=review > > > Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm:2556 > > +static inline bool isObscuredElement(Element& element) > > Why `IgnoreClipping`? Wouldn't you want to take clipping into account to > know if you can see the thing? Right – I've removed `IgnoreClipping`. Committed r271861: <https://trac.webkit.org/changeset/271861> All reviewed patches have been landed. Closing bug and clearing flags on attachment 418320 [details]. |