Bug 220929

Summary: [iOS] Obscured elements should not be focusable using the accessory bar
Product: WebKit Reporter: Aditya Keerthi <akeerthi>
Component: FormsAssignee: Aditya Keerthi <akeerthi>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, changseok, esprehn+autocc, ews-watchlist, glenn, kondapallykalyan, pdr, thorton, webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
thorton: review+
Patch for landing none

Description Aditya Keerthi 2021-01-25 09:25:02 PST
...
Comment 1 Aditya Keerthi 2021-01-25 09:25:17 PST
<rdar://problem/73239409>
Comment 2 Aditya Keerthi 2021-01-25 09:45:55 PST
Created attachment 418301 [details]
Patch
Comment 3 Tim Horton 2021-01-25 12:10:00 PST
Comment on attachment 418301 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=418301&action=review

> Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm:2556
> +static inline bool isObscuredElement(Element& element)

Why `IgnoreClipping`? Wouldn't you want to take clipping into account to know if you can see the thing?
Comment 4 Aditya Keerthi 2021-01-25 12:23:38 PST
Created attachment 418320 [details]
Patch for landing
Comment 5 Aditya Keerthi 2021-01-25 12:25:36 PST
(In reply to Tim Horton from comment #3)
> Comment on attachment 418301 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=418301&action=review
> 
> > Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm:2556
> > +static inline bool isObscuredElement(Element& element)
> 
> Why `IgnoreClipping`? Wouldn't you want to take clipping into account to
> know if you can see the thing?

Right – I've removed `IgnoreClipping`.
Comment 6 EWS 2021-01-25 14:52:02 PST
Committed r271861: <https://trac.webkit.org/changeset/271861>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 418320 [details].