Bug 220927

Summary: [macOS] Restrict access to dtracehelper
Product: WebKit Reporter: Per Arne Vollan <pvollan>
Component: WebKit Misc.Assignee: Per Arne Vollan <pvollan>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, iseenoface, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=221501
Attachments:
Description Flags
Patch
bfulgham: review+
Patch
none
Patch none

Per Arne Vollan
Reported 2021-01-25 08:44:39 PST
Only allow access to dtracehelper for internal installs.
Attachments
Patch (2.42 KB, patch)
2021-01-25 08:50 PST, Per Arne Vollan 		bfulgham: review+
DetailsFormatted DiffDiff
Patch (2.40 KB, patch)
2021-01-25 12:55 PST, Per Arne Vollan 		no flags
DetailsFormatted DiffDiff
Patch (2.20 KB, patch)
2021-01-25 13:10 PST, Per Arne Vollan 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Per Arne Vollan
Comment 1 2021-01-25 08:47:39 PST
<rdar://70350947>
Per Arne Vollan
Comment 2 2021-01-25 08:50:24 PST
Created attachment 418297 [details] Patch
Brent Fulgham
Comment 3 2021-01-25 11:35:04 PST
Comment on attachment 418297 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=418297&action=review r=me > Source/WebKit/WebProcess/com.apple.WebProcess.sb.in:89 > (with telemetry-backtrace) Should we remove this, given that telemetry-backtrace is a finite resource and we know this is needed for internal builds?
Per Arne Vollan
Comment 4 2021-01-25 12:55:03 PST
Created attachment 418324 [details] Patch
Per Arne Vollan
Comment 5 2021-01-25 12:55:37 PST
(In reply to Brent Fulgham from comment #3) > Comment on attachment 418297 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=418297&action=review > > r=me > > > Source/WebKit/WebProcess/com.apple.WebProcess.sb.in:89 > > (with telemetry-backtrace) > > Should we remove this, given that telemetry-backtrace is a finite resource > and we know this is needed for internal builds? Fixed, thanks for reviewing!
Per Arne Vollan
Comment 6 2021-01-25 13:10:28 PST
Created attachment 418328 [details] Patch
EWS
Comment 7 2021-01-25 14:09:58 PST
Committed r271815: <https://trac.webkit.org/changeset/271815> All reviewed patches have been landed. Closing bug and clearing flags on attachment 418328 [details].
Note You need to log in before you can comment on or make changes to this bug.