Bug 220907

Summary: Upstream to WPT Shadow DOM tests related to :focus pseudo-class
Product: WebKit Reporter: Manuel Rego Casasnovas <rego>
Component: Tools / TestsAssignee: Manuel Rego Casasnovas <rego>
Status: RESOLVED FIXED    
Severity: Normal CC: clopez, ews-watchlist, rniwa, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://github.com/web-platform-tests/wpt/pull/27303
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch ews-feeder: commit-queue-

Manuel Rego Casasnovas
Reported 2021-01-24 23:12:35 PST
These tests landed originally in r250788 (https://webkit.org/b/202432).
Attachments
Patch (23.73 KB, patch)
2021-01-24 23:14 PST, Manuel Rego Casasnovas 		no flags
DetailsFormatted DiffDiff
Patch (23.72 KB, patch)
2021-01-24 23:16 PST, Manuel Rego Casasnovas 		no flags
DetailsFormatted DiffDiff
Patch (23.73 KB, patch)
2021-01-24 23:58 PST, Manuel Rego Casasnovas 		no flags
DetailsFormatted DiffDiff
Patch (24.99 KB, patch)
2021-01-26 22:04 PST, Manuel Rego Casasnovas 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Manuel Rego Casasnovas
Comment 1 2021-01-24 23:14:06 PST
Created attachment 418251 [details] Patch
EWS Watchlist
Comment 2 2021-01-24 23:15:06 PST
This patch modifies the imported WPT tests. Please ensure that any changes on the tests (not coming from a WPT import) are exported to WPT. Please see https://trac.webkit.org/wiki/WPTExportProcess
Manuel Rego Casasnovas
Comment 3 2021-01-24 23:16:40 PST
Created attachment 418252 [details] Patch
Manuel Rego Casasnovas
Comment 4 2021-01-24 23:58:17 PST
Created attachment 418255 [details] Patch
Manuel Rego Casasnovas
Comment 5 2021-01-25 02:03:06 PST
The PR to be reviewed upstream is at: https://github.com/web-platform-tests/wpt/pull/27303
Ryosuke Niwa
Comment 6 2021-01-26 21:31:13 PST
Comment on attachment 418255 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=418255&action=review > LayoutTests/imported/w3c/ChangeLog:18 > + * web-platform-tests/shadow-dom/focus/focus-pseudo-on-shadow-host-3.html: Renamed from LayoutTests/fast/shadow-dom/focus-pseudo-on-shadow-host-3.html. Please unskip these tests in iOS.
Manuel Rego Casasnovas
Comment 7 2021-01-26 22:04:18 PST
Created attachment 418509 [details] Patch
Manuel Rego Casasnovas
Comment 8 2021-01-26 22:05:42 PST
Comment on attachment 418255 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=418255&action=review Thanks for the WPT review. Uploading new version unskipping tests in iOS. >> LayoutTests/imported/w3c/ChangeLog:18 >> + * web-platform-tests/shadow-dom/focus/focus-pseudo-on-shadow-host-3.html: Renamed from LayoutTests/fast/shadow-dom/focus-pseudo-on-shadow-host-3.html. > > Please unskip these tests in iOS. Done.
Ryosuke Niwa
Comment 9 2021-01-26 22:05:47 PST
Let's wait for EWS.
Manuel Rego Casasnovas
Comment 10 2021-01-27 03:21:30 PST
Comment on attachment 418509 [details] Patch Windows EWS failure is unrelated, so let's land this.
EWS
Comment 11 2021-01-27 03:41:25 PST
Committed r271944: <https://trac.webkit.org/changeset/271944> All reviewed patches have been landed. Closing bug and clearing flags on attachment 418509 [details].
Radar WebKit Bug Importer
Comment 12 2021-01-27 03:42:15 PST
<rdar://problem/73656853>
Note You need to log in before you can comment on or make changes to this bug.