Bug 220888

Summary: [JSC] DeferredWorkTimer should clear pending task after running
Product: WebKit Reporter: Yusuke Suzuki <ysuzuki>
Component: New BugsAssignee: Yusuke Suzuki <ysuzuki>
Status: RESOLVED FIXED    
Severity: Normal CC: ews-watchlist, keith_miller, mark.lam, msaboff, saam, tzagallo, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch mark.lam: review+

Yusuke Suzuki
Reported 2021-01-22 21:22:26 PST
[JSC] DeferredWorkTimer should clear pending task after running
Attachments
Patch (5.07 KB, patch)
2021-01-22 21:28 PST, Yusuke Suzuki 		no flags
DetailsFormatted DiffDiff
Patch (5.33 KB, patch)
2021-01-22 21:31 PST, Yusuke Suzuki 		no flags
DetailsFormatted DiffDiff
Patch (14.22 KB, patch)
2021-01-22 23:44 PST, Yusuke Suzuki 		no flags
DetailsFormatted DiffDiff
Patch (14.22 KB, patch)
2021-01-23 02:18 PST, Yusuke Suzuki 		mark.lam: review+
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Yusuke Suzuki
Comment 1 2021-01-22 21:28:15 PST
Created attachment 418210 [details] Patch
Yusuke Suzuki
Comment 2 2021-01-22 21:31:39 PST
Created attachment 418211 [details] Patch
Yusuke Suzuki
Comment 3 2021-01-22 23:12:08 PST
Comment on attachment 418211 [details] Patch Looking.
Yusuke Suzuki
Comment 4 2021-01-22 23:44:00 PST
Created attachment 418219 [details] Patch
Yusuke Suzuki
Comment 5 2021-01-23 02:18:20 PST
Created attachment 418220 [details] Patch
Mark Lam
Comment 6 2021-01-23 11:33:59 PST
Comment on attachment 418220 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=418220&action=review r=me > Source/JavaScriptCore/runtime/JSPromise.cpp:-186 > - vm.deferredWorkTimer->cancelPendingWork(this); Is there a reason to still keep DeferredWorkTimer::cancelPendingWork()? I see that you've removed all calls to it. If not, we should remove it.
Yusuke Suzuki
Comment 7 2021-01-23 14:07:48 PST
Comment on attachment 418220 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=418220&action=review >> Source/JavaScriptCore/runtime/JSPromise.cpp:-186 >> - vm.deferredWorkTimer->cancelPendingWork(this); > > Is there a reason to still keep DeferredWorkTimer::cancelPendingWork()? I see that you've removed all calls to it. If not, we should remove it. There are no users, so we can remove it :).
Yusuke Suzuki
Comment 8 2021-01-23 14:11:39 PST
Committed r271781: <https://trac.webkit.org/changeset/271781>
Radar WebKit Bug Importer
Comment 9 2021-01-23 14:12:16 PST
<rdar://problem/73539704>
Note You need to log in before you can comment on or make changes to this bug.