| Summary: | [JSC] DeferredWorkTimer should clear pending task after running | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Yusuke Suzuki <ysuzuki> | ||||||||||
| Component: | New Bugs | Assignee: | Yusuke Suzuki <ysuzuki> | ||||||||||
| Status: | RESOLVED FIXED | ||||||||||||
| Severity: | Normal | CC: | ews-watchlist, keith_miller, mark.lam, msaboff, saam, tzagallo, webkit-bug-importer | ||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||
| Version: | WebKit Nightly Build | ||||||||||||
| Hardware: | Unspecified | ||||||||||||
| OS: | Unspecified | ||||||||||||
| Attachments: |
|
||||||||||||
|
Description
Yusuke Suzuki
2021-01-22 21:22:26 PST
Created attachment 418210 [details]
Patch
Created attachment 418211 [details]
Patch
Comment on attachment 418211 [details]
Patch
Looking.
Created attachment 418219 [details]
Patch
Created attachment 418220 [details]
Patch
Comment on attachment 418220 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=418220&action=review r=me > Source/JavaScriptCore/runtime/JSPromise.cpp:-186 > - vm.deferredWorkTimer->cancelPendingWork(this); Is there a reason to still keep DeferredWorkTimer::cancelPendingWork()? I see that you've removed all calls to it. If not, we should remove it. Comment on attachment 418220 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=418220&action=review >> Source/JavaScriptCore/runtime/JSPromise.cpp:-186 >> - vm.deferredWorkTimer->cancelPendingWork(this); > > Is there a reason to still keep DeferredWorkTimer::cancelPendingWork()? I see that you've removed all calls to it. If not, we should remove it. There are no users, so we can remove it :). Committed r271781: <https://trac.webkit.org/changeset/271781> |