Bug 220874

Summary: Update availability annotations to match the macOS 11.0 and iOS 14.0 GM SDKs
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: WebKit2Assignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, beidson, darin, ews-watchlist, ggaren, keith_miller, mark.lam, msaboff, saam, tzagallo, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Description Chris Dumez 2021-01-22 11:46:52 PST 
Update availability annotations to match the macOS 11.0 and iOS 14.0 GM SDKs.
Comment 1 Chris Dumez 2021-01-22 11:47:07 PST 
<rdar://73474368>
Comment 2 Chris Dumez 2021-01-22 11:48:39 PST 
Created attachment 418166 [details]
Patch
Comment 3 Alexey Proskuryakov 2021-01-22 12:01:48 PST 
Comment on attachment 418166 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=418166&action=review

> Source/WebKit/UIProcess/API/Cocoa/WKNavigationDelegatePrivate.h:129
> +- (void)_webView:(WKWebView *)webView willGoToBackForwardListItem:(WKBackForwardListItem *)item inPageCache:(BOOL)inPageCache WK_API_AVAILABLE(macos(10.13.4), ios(14.0));

Can it really be that it's 10.13.4 on macOS, but a major release on iOS?
Comment 4 Alex Christensen 2021-01-22 12:03:09 PST 
Comment on attachment 418166 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=418166&action=review

>> Source/WebKit/UIProcess/API/Cocoa/WKNavigationDelegatePrivate.h:129
>> +- (void)_webView:(WKWebView *)webView willGoToBackForwardListItem:(WKBackForwardListItem *)item inPageCache:(BOOL)inPageCache WK_API_AVAILABLE(macos(10.13.4), ios(14.0));
> 
> Can it really be that it's 10.13.4 on macOS, but a major release on iOS?

Yes.  See https://trac.webkit.org/changeset/260546/webkit
Comment 5 Alexey Proskuryakov 2021-01-22 12:08:18 PST 
Comment on attachment 418166 [details]
Patch

Got it. Did we have anything shipped in update SDKs that needs to be annotated accordingly? Surprised to see no point update version in this patch.
Comment 6 Chris Dumez 2021-01-22 12:12:45 PST 
(In reply to Alexey Proskuryakov from comment #5)
> Comment on attachment 418166 [details]
> Patch
> 
> Got it. Did we have anything shipped in update SDKs that needs to be
> annotated accordingly? Surprised to see no point update version in this
> patch.

I have no idea. It was already a pain to have to check which new API were in macOS 11.0 and iOS 14.0 one by one.
Comment 7 Chris Dumez 2021-01-25 11:03:44 PST 
Created attachment 418310 [details]
Patch
Comment 8 Chris Dumez 2021-01-25 11:04:45 PST 
Ok, I went further back to macOS 10.15.4 & iOS 13.4 (which was our last WebKit major release before macOS 11.0 & iOS 14.0).
Comment 9 Darin Adler 2021-01-25 13:06:53 PST 
Comment on attachment 418310 [details]
Patch

Makes me wish we had a script to check our headers against the SDK. Tempted to write one.
Comment 10 EWS 2021-01-25 13:36:55 PST 
Committed r271813: <https://trac.webkit.org/changeset/271813>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 418310 [details].