Bug 22087

Summary:

Need correct platform defines for Mac Chromium.

Product:

WebKit

Reporter:

Mike Pinkerton <pinkerton>

Component:

WebCore Misc.

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

Priority:

Version:

528+ (Nightly build)

Hardware:

Mac

OS:

OS X 10.5

Attachments:

Description	Flags
patch file	sam: review+

Mike Pinkerton

Reported 2008-11-05 13:25:23 PST

Sets the appropriate platform defines for Mac Chromium, which behaves a lot like platform(mac), ie CG/CF/ATSUI/etc but won't be defining PLATFORM(MAC) because, well, it's not. :-) patch upcoming...

Attachments
patch file (1.32 KB, patch) 2008-11-05 13:25 PST, Mike Pinkerton	sam: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Mike Pinkerton

Comment 1 2008-11-05 13:25:58 PST

Created attachment 24916 [details] patch file

Sam Weinig

Comment 2 2008-11-05 13:34:17 PST

Comment on attachment 24916 [details] patch file You have some tabs in the ChangeLog, but otherwise, r=me.

Mike Pinkerton

Comment 3 2008-11-11 06:34:43 PST

this patch has been sitting with review+ for about a week, can someone land it? thanks ;)

Sam Weinig

Comment 4 2008-11-13 10:10:14 PST

Landed in r38372.

Note You need to log in before you can comment on or make changes to this bug.