Bug 22087 - Need correct platform defines for Mac Chromium.
Summary: Need correct platform defines for Mac Chromium.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-11-05 13:25 PST by Mike Pinkerton
Modified: 2008-11-13 10:10 PST (History)
0 users

See Also:


Attachments
patch file (1.32 KB, patch)
2008-11-05 13:25 PST, Mike Pinkerton
sam: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mike Pinkerton 2008-11-05 13:25:23 PST
Sets the appropriate platform defines for Mac Chromium, which behaves a lot like platform(mac), ie CG/CF/ATSUI/etc but won't be defining PLATFORM(MAC) because, well, it's not. :-)

patch upcoming...
Comment 1 Mike Pinkerton 2008-11-05 13:25:58 PST
Created attachment 24916 [details]
patch file
Comment 2 Sam Weinig 2008-11-05 13:34:17 PST
Comment on attachment 24916 [details]
patch file

You have some tabs in the ChangeLog, but otherwise, r=me.
Comment 3 Mike Pinkerton 2008-11-11 06:34:43 PST
this patch has been sitting with review+ for about a week, can someone land it? thanks ;)
Comment 4 Sam Weinig 2008-11-13 10:10:14 PST
Landed in r38372.