Summary: | DisplayList::Replayer should stop replay and inform clients after encountering an invalid item | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Wenson Hsieh <wenson_hsieh> | ||||||
Component: | WebCore Misc. | Assignee: | Wenson Hsieh <wenson_hsieh> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | cdumez, simon.fraser, thorton, webkit-bug-importer, youennf | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
See Also: | https://bugs.webkit.org/show_bug.cgi?id=220948 | ||||||||
Bug Depends on: | |||||||||
Bug Blocks: | 219097 | ||||||||
Attachments: |
|
Description
Wenson Hsieh
2021-01-22 10:15:35 PST
Created attachment 418157 [details]
Patch
Comment on attachment 418157 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=418157&action=review > Source/WebCore/platform/graphics/displaylists/DisplayList.h:129 > + m_isValid ? Optional<ItemHandle> {{ m_currentBufferForItem }} : WTF::nullopt, nit: makeOptional() may look nicer. > Tools/TestWebKitAPI/Tests/WebCore/cg/DisplayListTestsCG.cpp:42 > +static constexpr CGFloat contextWidth = 100; static is not needed since global & const. > Tools/TestWebKitAPI/Tests/WebCore/cg/DisplayListTestsCG.cpp:43 > +static constexpr CGFloat contextHeight = 100; ditto. Comment on attachment 418157 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=418157&action=review Thanks for the review! >> Source/WebCore/platform/graphics/displaylists/DisplayList.h:129 >> + m_isValid ? Optional<ItemHandle> {{ m_currentBufferForItem }} : WTF::nullopt, > > nit: makeOptional() may look nicer. Changed to use makeOptional(). >> Tools/TestWebKitAPI/Tests/WebCore/cg/DisplayListTestsCG.cpp:42 >> +static constexpr CGFloat contextWidth = 100; > > static is not needed since global & const. Removed the static. >> Tools/TestWebKitAPI/Tests/WebCore/cg/DisplayListTestsCG.cpp:43 >> +static constexpr CGFloat contextHeight = 100; > > ditto. 👍🏻 Created attachment 418168 [details]
Patch for landing
commit-queue failed to commit attachment 418168 [details] to WebKit repository.
Committed r271757: <https://trac.webkit.org/changeset/271757> |