Summary: | [GTK] run-gtk-tests: Crashing and non-existent tests should not count as a pass | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Alicia Boya García <aboya> | ||||||||||
Component: | Tools / Tests | Assignee: | Alicia Boya García <aboya> | ||||||||||
Status: | RESOLVED FIXED | ||||||||||||
Severity: | Normal | CC: | bugs-noreply, mcatanzaro, webkit-bug-importer | ||||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||||
Version: | WebKit Nightly Build | ||||||||||||
Hardware: | Unspecified | ||||||||||||
OS: | Unspecified | ||||||||||||
See Also: | https://bugs.webkit.org/show_bug.cgi?id=220938 | ||||||||||||
Attachments: |
|
Description
Alicia Boya García
2021-01-22 08:59:28 PST
Created attachment 418152 [details]
Patch
Created attachment 418421 [details]
Patch
Uploaded an updated version that marks these tests as CRASH. I expect the EWS to fail on the test suites that are currently crashing. (In reply to Alicia Boya García from comment #3) > Uploaded an updated version that marks these tests as CRASH. I expect the > EWS to fail on the test suites that are currently crashing. Well, EWS didn't fail because the crashes have been fixed in the meantime. Now the previously crashing test suites are reporting subtests again. TEST: /app/webkit/Tools/glib/../../WebKitBuild/Release/bin/TestWebKitAPI/WebKit2Gtk/TestCookieManager... /webkit/WebKitCookieManager/accept-policy: PASS TEST: /app/webkit/Tools/glib/../../WebKitBuild/Release/bin/TestWebKitAPI/WebKit2Gtk/TestBackForwardList... /webkit/BackForwardList/navigation: PASS TEST: /app/webkit/Tools/glib/../../WebKitBuild/Release/bin/TestWebKitAPI/WebKit2Gtk/TestLoaderClient... /webkit/WebKitWebView/loading-status: PASS ... and so on. Created attachment 418538 [details]
Patch
Reuploaded removing the ChangeLog line about changing expectations since it's no longer necessary. Remember to CC bugs-noreply@webkitgtk.org if you're not using the GTK or WPE component, so it doesn't get missed! Comment on attachment 418538 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=418538&action=review > Tools/glib/api_test_runner.py:308 > + # No subtests where emitted, either the test binary didn't exist, or we don't know how to run it, or it crashed. were Created attachment 418550 [details]
Patch
Committed r271955: <https://trac.webkit.org/changeset/271955> All reviewed patches have been landed. Closing bug and clearing flags on attachment 418550 [details]. |