Bug 220860

Summary: [GTK] run-gtk-tests: Use sys.exit(1) instead of return 1
Product: WebKit Reporter: Alicia Boya García <aboya>
Component: Tools / TestsAssignee: Alicia Boya García <aboya>
Status: RESOLVED FIXED    
Severity: Normal CC: pnormand, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Alicia Boya García
Reported 2021-01-22 06:55:28 PST
Several parts of the code in api_test_runner.py returned 1 on failure. While common for main() functions, this is bad in functions that are expected to return something else than an exit code, and lets the program run after the error. sys.exit(1) should be used in those cases instead.
Attachments
Patch (1.86 KB, patch)
2021-01-22 07:04 PST, Alicia Boya García 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Alicia Boya García
Comment 1 2021-01-22 07:04:01 PST
Created attachment 418146 [details] Patch
EWS
Comment 2 2021-01-25 02:23:12 PST
Committed r271789: <https://trac.webkit.org/changeset/271789> All reviewed patches have been landed. Closing bug and clearing flags on attachment 418146 [details].
Radar WebKit Bug Importer
Comment 3 2021-01-25 02:24:13 PST
<rdar://problem/73564098>
Note You need to log in before you can comment on or make changes to this bug.