Bug 220860

Summary:

[GTK] run-gtk-tests: Use sys.exit(1) instead of return 1

Product:

WebKit

Reporter:

Alicia Boya García <aboya>

Component:

Tools / Tests

Assignee:

Alicia Boya García <aboya>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

pnormand, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Description Alicia Boya García 2021-01-22 06:55:28 PST

Several parts of the code in api_test_runner.py returned 1 on failure.
While common for main() functions, this is bad in functions that are
expected to return something else than an exit code, and lets the
program run after the error. sys.exit(1) should be used in those cases
instead.

Comment 1 Alicia Boya García 2021-01-22 07:04:01 PST

Created attachment 418146 [details]
Patch

Comment 2 EWS 2021-01-25 02:23:12 PST

Committed r271789: <https://trac.webkit.org/changeset/271789>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 418146 [details].

Comment 3 Radar WebKit Bug Importer 2021-01-25 02:24:13 PST

<rdar://problem/73564098>