Bug 220860 - [GTK] run-gtk-tests: Use sys.exit(1) instead of return 1
Summary: [GTK] run-gtk-tests: Use sys.exit(1) instead of return 1
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alicia Boya García
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-01-22 06:55 PST by Alicia Boya García
Modified: 2021-01-25 02:24 PST (History)
2 users (show)

See Also:

Attachments
Patch (1.86 KB, patch)
2021-01-22 07:04 PST, Alicia Boya García 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alicia Boya García 2021-01-22 06:55:28 PST 
Several parts of the code in api_test_runner.py returned 1 on failure.
While common for main() functions, this is bad in functions that are
expected to return something else than an exit code, and lets the
program run after the error. sys.exit(1) should be used in those cases
instead.
Comment 1 Alicia Boya García 2021-01-22 07:04:01 PST 
Created attachment 418146 [details]
Patch
Comment 2 EWS 2021-01-25 02:23:12 PST 
Committed r271789: <https://trac.webkit.org/changeset/271789>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 418146 [details].
Comment 3 Radar WebKit Bug Importer 2021-01-25 02:24:13 PST 
<rdar://problem/73564098>