Bug 220856
| Summary: | TransformationMatrix::Recompose() and Decompose() incorrectly transpose rotation | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Imanol Fernandez <ifernandez> |
| Component: | Animations | Assignee: | Matt Woodrow <mattwoodrow> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | cdumez, dino, graouts, krit, mrobinson, simon.fraser, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | All | ||
| OS: | All | ||
Imanol Fernandez
The computation of quaternions during matrix decomposition looks like it's based off of the matrix transpose. The matrix data is actually column major order but the quaternion operations seem to assume row major order.
More info in the equivalent chromium bug:
https://bugs.chromium.org/p/chromium/issues/detail?id=929841
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/73747851>
Matt Woodrow
Pull request: https://github.com/WebKit/WebKit/pull/17162
EWS
Committed 267424@main (a959acf1111c): <https://commits.webkit.org/267424@main>
Reviewed commits have been landed. Closing PR #17162 and removing active labels.