Summary: | MotionMark scores are super sensitive to a single long frame | ||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Myles C. Maxfield <mmaxfield> | ||||||||||||||||
Component: | New Bugs | Assignee: | Myles C. Maxfield <mmaxfield> | ||||||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||||||
Severity: | Normal | CC: | cdumez, commit-queue, ews-watchlist, jbedard, jonlee, mjs, rniwa, sabouhallawa, webkit-bug-importer | ||||||||||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||||||||||
Version: | WebKit Nightly Build | ||||||||||||||||||
Hardware: | Unspecified | ||||||||||||||||||
OS: | Unspecified | ||||||||||||||||||
Bug Depends on: | 222449 | ||||||||||||||||||
Bug Blocks: | |||||||||||||||||||
Attachments: |
|
Description
Myles C. Maxfield
2021-01-22 00:50:42 PST
Created attachment 418116 [details]
WIP
*** This bug has been marked as a duplicate of bug 221075 *** Reopening because the problem seems to still exist after r272044 Created attachment 420553 [details]
Patch
Comment on attachment 420553 [details]
Patch
I'm not an expert on MotionMark, but to the extent I understand the intent of this patch, it seems to do what its supposed to.
lgtm. Committed r273122 (234319@main): <https://commits.webkit.org/234319@main> Committed r273123 (234320@main): <https://commits.webkit.org/234320@main> Re-opened since this is blocked by bug 222449 Created attachment 422546 [details]
Patch
Created attachment 422587 [details]
Patch
Created attachment 422681 [details]
Patch
Comment on attachment 422681 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=422681&action=review > PerformanceTests/ChangeLog:17 > + a complexity that was 3.16x of the previous complexity. This patch changes that to 1.5x of the previous Whoops, this is actually 1.778x Created attachment 422756 [details]
Patch for committing
Created attachment 422757 [details]
Patch for committing
Committed r274179: <https://commits.webkit.org/r274179> All reviewed patches have been landed. Closing bug and clearing flags on attachment 422757 [details]. Committed r274183 (235102@main): <https://commits.webkit.org/235102@main> |