Bug 220847

Summary: MotionMark scores are super sensitive to a single long frame
Product: WebKit Reporter: Myles C. Maxfield <mmaxfield>
Component: New BugsAssignee: Myles C. Maxfield <mmaxfield>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, commit-queue, ews-watchlist, jbedard, jonlee, mjs, rniwa, sabouhallawa, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 222449    
Bug Blocks:    
Attachments:
Description Flags
WIP
none
Patch
none
Patch
none
Patch
none
Patch
jonlee: review+
Patch for committing
none
Patch for committing none

Myles C. Maxfield
Reported 2021-01-22 00:50:42 PST
MotionMark scores are super sensitive to a single long frame
Attachments
WIP (6.79 KB, patch)
2021-01-22 00:58 PST, Myles C. Maxfield 		no flags
DetailsFormatted DiffDiff
Patch (6.77 KB, patch)
2021-02-16 15:48 PST, Myles C. Maxfield 		no flags
DetailsFormatted DiffDiff
Patch (10.08 KB, patch)
2021-03-07 23:45 PST, Myles C. Maxfield 		no flags
DetailsFormatted DiffDiff
Patch (10.08 KB, patch)
2021-03-08 11:06 PST, Myles C. Maxfield 		no flags
DetailsFormatted DiffDiff
Patch (8.10 KB, patch)
2021-03-09 02:10 PST, Myles C. Maxfield 		jonlee: review+
DetailsFormatted DiffDiff
Patch for committing (8.22 KB, patch)
2021-03-09 14:16 PST, Myles C. Maxfield 		no flags
DetailsFormatted DiffDiff
Patch for committing (8.22 KB, patch)
2021-03-09 14:16 PST, Myles C. Maxfield 		no flags
DetailsFormatted DiffDiff
Show Obsolete (5) View All Add attachment proposed patch, testcase, etc.
Myles C. Maxfield
Comment 1 2021-01-22 00:58:13 PST
Created attachment 418116 [details] WIP
Myles C. Maxfield
Comment 2 2021-01-27 19:39:08 PST
*** This bug has been marked as a duplicate of bug 221075 ***
Myles C. Maxfield
Comment 3 2021-02-16 15:42:34 PST
Reopening because the problem seems to still exist after r272044
Myles C. Maxfield
Comment 4 2021-02-16 15:46:30 PST
<rdar://problem/74152743>
Myles C. Maxfield
Comment 5 2021-02-16 15:48:23 PST
Created attachment 420553 [details] Patch
Maciej Stachowiak
Comment 6 2021-02-17 15:59:09 PST
Comment on attachment 420553 [details] Patch I'm not an expert on MotionMark, but to the extent I understand the intent of this patch, it seems to do what its supposed to.
Jon Lee
Comment 7 2021-02-18 00:23:49 PST
lgtm.
Myles C. Maxfield
Comment 8 2021-02-18 19:30:03 PST
Committed r273122 (234319@main): <https://commits.webkit.org/234319@main>
Myles C. Maxfield
Comment 9 2021-02-18 19:35:24 PST
Committed r273123 (234320@main): <https://commits.webkit.org/234320@main>
WebKit Commit Bot
Comment 10 2021-02-25 18:39:04 PST
Re-opened since this is blocked by bug 222449
Myles C. Maxfield
Comment 11 2021-03-07 23:45:07 PST
Created attachment 422546 [details] Patch
Myles C. Maxfield
Comment 12 2021-03-08 11:06:06 PST
Created attachment 422587 [details] Patch
Myles C. Maxfield
Comment 13 2021-03-09 02:10:01 PST
Created attachment 422681 [details] Patch
Myles C. Maxfield
Comment 14 2021-03-09 13:41:56 PST
Comment on attachment 422681 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=422681&action=review > PerformanceTests/ChangeLog:17 > + a complexity that was 3.16x of the previous complexity. This patch changes that to 1.5x of the previous Whoops, this is actually 1.778x
Myles C. Maxfield
Comment 15 2021-03-09 14:16:04 PST
Created attachment 422756 [details] Patch for committing
Myles C. Maxfield
Comment 16 2021-03-09 14:16:57 PST
Created attachment 422757 [details] Patch for committing
EWS
Comment 17 2021-03-09 15:08:46 PST
Committed r274179: <https://commits.webkit.org/r274179> All reviewed patches have been landed. Closing bug and clearing flags on attachment 422757 [details].
Myles C. Maxfield
Comment 18 2021-03-09 15:50:26 PST
Committed r274183 (235102@main): <https://commits.webkit.org/235102@main>
Note You need to log in before you can comment on or make changes to this bug.