Bug 220813

Summary: Null dereference in CompositeEditCommand::cloneParagraphUnderNewElement(): needs to check lastNode parent
Product: WebKit Reporter: Julian Gonzalez <julian_a_gonzalez>
Component: HTML EditingAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: ews-watchlist, mifenton, rniwa, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Julian Gonzalez
Reported 2021-01-21 12:31:07 PST
e.g. frame #0: WebCore`WebCore::Node::parentNode() const+0 frame #1: WebCore`WebCore::CompositeEditCommand::cloneParagraphUnderNewElement(WebCore::Position const&, WebCore::Position const&, WebCore::Node*, WebCore::Element*)+0 frame #2: WebCore`WebCore::CompositeEditCommand::moveParagraphWithClones(WebCore::VisiblePosition const&, WebCore::VisiblePosition const&, WebCore::Element*, WebCore::Node*)+0 frame #3: WebCore`WebCore::IndentOutdentCommand::indentIntoBlockquote(WebCore::Position const&, WebCore::Position const&, WTF::RefPtr<WebCore::Element, WTF::DumbPtrTraits<WebCore::Element> >&)+0 frame #4: WebCore`WebCore::ApplyBlockElementCommand::formatSelection(WebCore::VisiblePosition const&, WebCore::VisiblePosition const&)+0 frame #5: WebCore`WebCore::ApplyBlockElementCommand::doApply()+0 frame #6: WebCore`WebCore::CompositeEditCommand::apply()+0 frame #7: WebCore`WebCore::executeIndent(WebCore::Frame&, WebCore::Event*, WebCore::EditorCommandSource, WTF::String const&)+0 frame #8: WebCore`WebCore::Document::execCommand(WTF::String const&, bool, WTF::String const&)+0 <rdar://problem/66894117>
Attachments
Patch (4.44 KB, patch)
2021-01-21 12:42 PST, Julian Gonzalez 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Julian Gonzalez
Comment 1 2021-01-21 12:42:26 PST
Created attachment 418070 [details] Patch
Julian Gonzalez
Comment 2 2021-01-21 15:42:58 PST
Real radar: <rdar://problem/72194329>
EWS
Comment 3 2021-01-21 15:43:28 PST
Committed r271720: <https://trac.webkit.org/changeset/271720> All reviewed patches have been landed. Closing bug and clearing flags on attachment 418070 [details].
Note You need to log in before you can comment on or make changes to this bug.