Bug 220811

Summary: Add WebXR to features.json
Product: WebKit Reporter: Myles C. Maxfield <mmaxfield>
Component: New BugsAssignee: Myles C. Maxfield <mmaxfield>
Status: RESOLVED FIXED    
Severity: Normal CC: dino, ews-watchlist, joepeck, simon.fraser, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
simon.fraser: review+
Patch for committing none

Myles C. Maxfield
Reported 2021-01-21 11:20:05 PST
Add WebXR to features.json
Attachments
Patch (1.81 KB, patch)
2021-01-21 11:22 PST, Myles C. Maxfield 		simon.fraser: review+
DetailsFormatted DiffDiff
Patch for committing (1.77 KB, patch)
2021-01-21 11:49 PST, Myles C. Maxfield 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Myles C. Maxfield
Comment 1 2021-01-21 11:22:01 PST
Created attachment 418065 [details] Patch
Simon Fraser (smfr)
Comment 2 2021-01-21 11:29:29 PST
Comment on attachment 418065 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=418065&action=review > Source/WebCore/features.json:822 > + "enabled-by-default": true Let's remove this. > Source/WebCore/features.json:826 > + "keywords": ["webxr", "webgl", "webgpu"], are webgl and webgpu relevant?
Myles C. Maxfield
Comment 3 2021-01-21 11:33:05 PST
Comment on attachment 418065 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=418065&action=review >> Source/WebCore/features.json:826 >> + "keywords": ["webxr", "webgl", "webgpu"], > > are webgl and webgpu relevant? yes! XR without webgl/webgpu is hardly an XR at all!
Myles C. Maxfield
Comment 4 2021-01-21 11:49:12 PST
Created attachment 418066 [details] Patch for committing
Dean Jackson
Comment 5 2021-01-21 12:09:22 PST
Comment on attachment 418065 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=418065&action=review >> Source/WebCore/features.json:822 >> + "enabled-by-default": true > > Let's remove this. it's definitely not on by default
EWS
Comment 6 2021-01-21 16:12:52 PST
Committed r271721: <https://trac.webkit.org/changeset/271721> All reviewed patches have been landed. Closing bug and clearing flags on attachment 418066 [details].
Radar WebKit Bug Importer
Comment 7 2021-01-21 16:13:14 PST
<rdar://problem/73473944>
Note You need to log in before you can comment on or make changes to this bug.