Bug 220795

Summary: [webkitcorepy] Don't import six at the top level
Product: WebKit Reporter: Angelos Oikonomopoulos <angelos>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: aakash_jain, dewei_zhu, jbedard, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Angelos Oikonomopoulos
Reported 2021-01-21 07:06:10 PST
[webkitcorepy] Don't import six at the top level
Attachments
Patch (2.00 KB, patch)
2021-01-21 07:10 PST, Angelos Oikonomopoulos 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Angelos Oikonomopoulos
Comment 1 2021-01-21 07:10:47 PST
Created attachment 418037 [details] Patch
Aakash Jain
Comment 2 2021-01-21 08:05:32 PST
Comment on attachment 418037 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=418037&action=review > Tools/Scripts/libraries/webkitcorepy/webkitcorepy/task_pool.py:338 > + from six import reraise Do we need to import it again whiling exiting?
Jonathan Bedard
Comment 3 2021-01-21 08:20:37 PST
Comment on attachment 418037 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=418037&action=review >> Tools/Scripts/libraries/webkitcorepy/webkitcorepy/task_pool.py:338 >> + from six import reraise > > Do we need to import it again whiling exiting? We do, because we use it on line 352
EWS
Comment 4 2021-01-21 08:52:11 PST
Committed r271692: <https://trac.webkit.org/changeset/271692> All reviewed patches have been landed. Closing bug and clearing flags on attachment 418037 [details].
Radar WebKit Bug Importer
Comment 5 2021-01-21 08:54:51 PST
<rdar://problem/73454252>
Aakash Jain
Comment 6 2021-01-21 14:37:23 PST
*** Bug 220791 has been marked as a duplicate of this bug. ***
Note You need to log in before you can comment on or make changes to this bug.