| Summary: | Further propagate ChildChange::Source to optimize HTMLInputElement creation | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Yusuke Suzuki <ysuzuki> | ||||||
| Component: | New Bugs | Assignee: | Yusuke Suzuki <ysuzuki> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | cdumez, changseok, esprehn+autocc, ews-watchlist, gyuyoung.kim, kangil.han, koivisto, mifenton, rniwa, simon.fraser, webkit-bug-importer | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Bug Depends on: | 220758 | ||||||||
| Bug Blocks: | |||||||||
| Attachments: |
|
||||||||
|
Description
Yusuke Suzuki
2021-01-20 19:42:29 PST
Created attachment 418014 [details]
Patch
Comment on attachment 418014 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=418014&action=review Hm... it's a bit scary because parser* variants aren't safe to use in some cases but we'd see how it goes. > Source/WebCore/dom/ContainerNode.cpp:494 > + // insertBefore(node, null) is equivalent to appendChild(node) I don't think we need this comment. Remove? Comment on attachment 418014 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=418014&action=review Yes, I tried removing scary things, and attempt to use it in a safe places now. Uploading. >> Source/WebCore/dom/ContainerNode.cpp:494 >> + // insertBefore(node, null) is equivalent to appendChild(node) > > I don't think we need this comment. Remove? Removed. Created attachment 418021 [details]
Patch
Committed r271686: <https://trac.webkit.org/changeset/271686> |