Bug 220778

Summary: Forbid '|' in URL hosts
Product: WebKit Reporter: Alex Christensen <achristensen>
Component: New BugsAssignee: Alex Christensen <achristensen>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, cdumez, clopez, cmarcelo, ews-watchlist, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
ews-feeder: commit-queue-
Patch
none
Patch none

Alex Christensen
Reported 2021-01-20 12:50:49 PST
Forbid '|' in URL hosts
Attachments
Patch (21.80 KB, patch)
2021-01-20 12:53 PST, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (22.36 KB, patch)
2021-01-20 12:57 PST, Alex Christensen 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (23.48 KB, patch)
2021-01-20 17:07 PST, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (30.35 KB, patch)
2021-01-26 10:26 PST, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Alex Christensen
Comment 1 2021-01-20 12:53:04 PST
Created attachment 417990 [details] Patch
EWS Watchlist
Comment 2 2021-01-20 12:54:09 PST
This patch modifies the imported WPT tests. Please ensure that any changes on the tests (not coming from a WPT import) are exported to WPT. Please see https://trac.webkit.org/wiki/WPTExportProcess
Alex Christensen
Comment 3 2021-01-20 12:57:59 PST
Created attachment 417991 [details] Patch
Alex Christensen
Comment 4 2021-01-20 17:07:39 PST
Created attachment 418006 [details] Patch
youenn fablet
Comment 5 2021-01-20 23:52:28 PST
Comment on attachment 418006 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=418006&action=review > LayoutTests/fast/url/file-http-base-expected.txt:13 > +FAIL canonicalize('//C|/foo/bar') should be file:///C:/foo/bar. Was //C|/foo/bar. Should we update this test?
Alex Christensen
Comment 6 2021-01-21 09:18:19 PST
Comment on attachment 418006 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=418006&action=review >> LayoutTests/fast/url/file-http-base-expected.txt:13 >> +FAIL canonicalize('//C|/foo/bar') should be file:///C:/foo/bar. Was //C|/foo/bar. > > Should we update this test? I don't think so. It failed before and after, and most of the tests in this file fail.
EWS
Comment 7 2021-01-21 09:21:32 PST
commit-queue failed to commit attachment 418006 [details] to WebKit repository.
youenn fablet
Comment 8 2021-01-21 09:25:03 PST
(In reply to Alex Christensen from comment #6) > Comment on attachment 418006 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=418006&action=review > > >> LayoutTests/fast/url/file-http-base-expected.txt:13 > >> +FAIL canonicalize('//C|/foo/bar') should be file:///C:/foo/bar. Was //C|/foo/bar. > > > > Should we update this test? > > I don't think so. It failed before and after, and most of the tests in this > file fail. So we should probably update the test so as to PASS (or remove the test).
Alex Christensen
Comment 9 2021-01-26 10:26:12 PST
Created attachment 418443 [details] Patch
EWS
Comment 10 2021-01-26 13:14:39 PST
Committed r271899: <https://trac.webkit.org/changeset/271899> All reviewed patches have been landed. Closing bug and clearing flags on attachment 418443 [details].
Radar WebKit Bug Importer
Comment 11 2021-01-26 13:15:18 PST
<rdar://problem/73629875>
Note You need to log in before you can comment on or make changes to this bug.