Bug 220770

Summary: [GPUProcess] Mark IOSurface backing for RemoteGraphicsContextGL's displayBuffer as owned by the WebProcess
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: WebKit2Assignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: ggaren, kkinnunen, simon.fraser, thorton, webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=220663
Bug Depends on:    
Bug Blocks: 231075    
Attachments:
Description Flags
Patch
none
Patch none

Chris Dumez
Reported 2021-01-20 09:32:56 PST
Mark IOSurface backing for RemoteGraphicsContextGL's displayBuffer as owned by the WebProcess. This is so that Jetsam knows which process to terminate to reclaim memory.
Attachments
Patch (6.08 KB, patch)
2021-01-20 09:34 PST, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (7.26 KB, patch)
2021-01-21 10:29 PST, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2021-01-20 09:34:31 PST
Created attachment 417977 [details] Patch
Kimmo Kinnunen
Comment 2 2021-01-20 09:50:55 PST
Could we do it already today in GPU process instead, so that we don't need to do that later?
Chris Dumez
Comment 3 2021-01-20 09:53:29 PST
(In reply to Kimmo Kinnunen from comment #2) > Could we do it already today in GPU process instead, so that we don't need > to do that later? ahah, I wish :) Sadly it is currently not possible to do so from the GPUProcess without opening the sandbox too much. I have a meeting about this soon though. If and when we have an SPI that works from the GPUProcess (and with acceptable security ramifications), I will update our code accordingly. For now, doing it from the WebProcess is that best we can do and the approach we have taken in Bug 220663 as well.
Geoffrey Garen
Comment 4 2021-01-20 13:55:02 PST
Comment on attachment 417977 [details] Patch r=me
EWS
Comment 5 2021-01-20 14:07:54 PST
Committed r271673: <https://trac.webkit.org/changeset/271673> All reviewed patches have been landed. Closing bug and clearing flags on attachment 417977 [details].
Radar WebKit Bug Importer
Comment 6 2021-01-20 14:08:15 PST
<rdar://problem/73419639>
Chris Dumez
Comment 7 2021-01-21 10:29:10 PST
Reopening to attach new patch.
Chris Dumez
Comment 8 2021-01-21 10:29:11 PST
Created attachment 418058 [details] Patch
Note You need to log in before you can comment on or make changes to this bug.