Bug 220762

Summary: BuildbotTriggerable should not update build requests from another triggerable.
Product: WebKit Reporter: dewei_zhu
Component: New BugsAssignee: dewei_zhu
Status: RESOLVED FIXED    
Severity: Normal CC: dewei_zhu, rniwa
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch for landing none

dewei_zhu
Reported 2021-01-19 22:38:28 PST
BuildbotTriggerable should not update build requests from another triggerable.
Attachments
Patch (21.19 KB, patch)
2021-01-19 23:10 PST, dewei_zhu 		no flags
DetailsFormatted DiffDiff
Patch (21.20 KB, patch)
2021-01-19 23:33 PST, dewei_zhu 		no flags
DetailsFormatted DiffDiff
Patch for landing (21.20 KB, patch)
2021-01-19 23:39 PST, dewei_zhu 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
dewei_zhu
Comment 1 2021-01-19 23:10:41 PST
Created attachment 417943 [details] Patch
dewei_zhu
Comment 2 2021-01-19 23:13:30 PST
rdar://73166544 rdar://72347539
Ryosuke Niwa
Comment 3 2021-01-19 23:20:57 PST
Comment on attachment 417943 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=417943&action=review > Websites/perf.webkit.org/public/api/build-requests.php:53 > + $update_fields = array(); This should be either fields_to_update or updated_fields.
dewei_zhu
Comment 4 2021-01-19 23:33:34 PST
Created attachment 417945 [details] Patch
dewei_zhu
Comment 5 2021-01-19 23:39:45 PST
Created attachment 417946 [details] Patch for landing
EWS
Comment 6 2021-01-20 00:32:01 PST
Committed r271639: <https://trac.webkit.org/changeset/271639> All reviewed patches have been landed. Closing bug and clearing flags on attachment 417946 [details].
Note You need to log in before you can comment on or make changes to this bug.