Bug 220762 - BuildbotTriggerable should not update build requests from another triggerable.
Summary: BuildbotTriggerable should not update build requests from another triggerable.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: dewei_zhu
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-01-19 22:38 PST by dewei_zhu
Modified: 2021-01-20 00:32 PST (History)
2 users (show)

See Also:


Attachments
Patch (21.19 KB, patch)
2021-01-19 23:10 PST, dewei_zhu
no flags Details | Formatted Diff | Diff
Patch (21.20 KB, patch)
2021-01-19 23:33 PST, dewei_zhu
no flags Details | Formatted Diff | Diff
Patch for landing (21.20 KB, patch)
2021-01-19 23:39 PST, dewei_zhu
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description dewei_zhu 2021-01-19 22:38:28 PST
BuildbotTriggerable should not update build requests from another triggerable.
Comment 1 dewei_zhu 2021-01-19 23:10:41 PST
Created attachment 417943 [details]
Patch
Comment 2 dewei_zhu 2021-01-19 23:13:30 PST
rdar://73166544
rdar://72347539
Comment 3 Ryosuke Niwa 2021-01-19 23:20:57 PST
Comment on attachment 417943 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=417943&action=review

> Websites/perf.webkit.org/public/api/build-requests.php:53
> +        $update_fields = array();

This should be either fields_to_update or updated_fields.
Comment 4 dewei_zhu 2021-01-19 23:33:34 PST
Created attachment 417945 [details]
Patch
Comment 5 dewei_zhu 2021-01-19 23:39:45 PST
Created attachment 417946 [details]
Patch for landing
Comment 6 EWS 2021-01-20 00:32:01 PST
Committed r271639: <https://trac.webkit.org/changeset/271639>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 417946 [details].