| Summary: | Remove remaining non-standard CMYKA support from canvas | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Sam Weinig <sam> | ||||||
| Component: | Canvas | Assignee: | Sam Weinig <sam> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | cdumez, changseok, darin, dino, esprehn+autocc, ews-watchlist, gyuyoung.kim, hi, kondapallykalyan, webkit-bug-importer, wenson_hsieh | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | All | ||||||||
| OS: | All | ||||||||
| Attachments: |
|
||||||||
|
Description
Sam Weinig
2021-01-19 19:03:05 PST
Created attachment 417938 [details]
Patch
Comment on attachment 417938 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=417938&action=review > Source/WebCore/ChangeLog:10 > + In r267645, most of the non-standard CMYKA taking functions on `CanvasRenderingContext2D` > + were removed, leaving only the `setShadow` overload left. This finishes that removal and > + cleans up some dead declarations that were left behind. You’re implying but not stating here that we have some confidence no one is relying on this setShadow overload that we left by accident. Comment on attachment 417938 [details]
Patch
r=me (assuming EWS is green)
(In reply to Darin Adler from comment #2) > Comment on attachment 417938 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=417938&action=review > > > Source/WebCore/ChangeLog:10 > > + In r267645, most of the non-standard CMYKA taking functions on `CanvasRenderingContext2D` > > + were removed, leaving only the `setShadow` overload left. This finishes that removal and > > + cleans up some dead declarations that were left behind. > > You’re implying but not stating here that we have some confidence no one is > relying on this setShadow overload that we left by accident. I am, but I should state it more clearly. I will probably also need to rebase some tests, so I will update the ChangeLog when I do that. Thanks (glad you have the review+ back too, it was a rough couple of minutes :) ). Created attachment 417959 [details]
Patch
Committed r271646: <https://trac.webkit.org/changeset/271646> All reviewed patches have been landed. Closing bug and clearing flags on attachment 417959 [details]. |