Summary: | REGRESSION (r271559): [BigSur] fast/forms/password-scrolled-after-caps-lock-toggled.html is consistently failing | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Ryan Haddad <ryanhaddad> | ||||||
Component: | Scrolling | Assignee: | Nikolas Zimmermann <zimmermann> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | changseok, esprehn+autocc, ews-watchlist, fred.wang, glenn, kondapallykalyan, pdr, simon.fraser, webkit-bot-watchers-bugzilla, webkit-bug-importer, wenson_hsieh, zimmermann | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
See Also: | https://bugs.webkit.org/show_bug.cgi?id=60305 | ||||||||
Attachments: |
|
Description
Ryan Haddad
2021-01-19 12:52:03 PST
I'll go ahead and revert this change since we have a confirmed regression point. (In reply to Ryan Haddad from comment #2) > I'll go ahead and revert this change since we have a confirmed regression > point. https://trac.webkit.org/changeset/271598/webkit would also need to go, so maybe this needs a look sooner rather than later. Rollouts will cause a lot of churn with these big patches, and Nikolas will look at this soon, so I'd prefer to hold off on the rollout. Regression confirmed, will look into it right now. Created attachment 418029 [details]
Patch
While this fixes the regression on the fast/forms/password-...* text, it has side effects for two other test categories, that I'm investigating. I'm on it - stay tuned. I'm sure it's obvious, but you just need to match the behavior from before the RenderLayer split. Created attachment 418094 [details]
Patch
Committed r271732: <https://trac.webkit.org/changeset/271732> All reviewed patches have been landed. Closing bug and clearing flags on attachment 418094 [details]. |