Bug 220706

Summary: Introduce a MediaSessionGroupIdentifier
Product: WebKit Reporter: youenn fablet <youennf>
Component: MediaAssignee: youenn fablet <youennf>
Status: RESOLVED FIXED    
Severity: Normal CC: annulen, calvaris, cdumez, changseok, eric.carlson, esprehn+autocc, ews-watchlist, glenn, gyuyoung.kim, jer.noble, kangil.han, philipj, ryuan.choi, sergio, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Local Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
ews-feeder: commit-queue-
Patch
ews-feeder: commit-queue-
Patch
none
Patch
none
Patch for landing
ews-feeder: commit-queue-
Patch for landing none

youenn fablet
Reported 2021-01-18 01:55:06 PST
Introduce a MediaSessionGroupIdentifier
Attachments
Patch (25.72 KB, patch)
2021-01-18 01:59 PST, youenn fablet 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (27.71 KB, patch)
2021-01-18 02:14 PST, youenn fablet 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (28.30 KB, patch)
2021-01-18 02:47 PST, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch (28.26 KB, patch)
2021-01-18 07:06 PST, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch for landing (28.57 KB, patch)
2021-01-20 00:49 PST, youenn fablet 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch for landing (28.58 KB, patch)
2021-01-20 01:05 PST, youenn fablet 		no flags
DetailsFormatted DiffDiff
Show Obsolete (5) View All Add attachment proposed patch, testcase, etc.
youenn fablet
Comment 1 2021-01-18 01:59:31 PST
Created attachment 417819 [details] Patch
youenn fablet
Comment 2 2021-01-18 02:14:14 PST
Created attachment 417820 [details] Patch
youenn fablet
Comment 3 2021-01-18 02:47:07 PST
Created attachment 417822 [details] Patch
youenn fablet
Comment 4 2021-01-18 07:06:36 PST
Created attachment 417830 [details] Patch
youenn fablet
Comment 5 2021-01-18 09:24:17 PST
Comment on attachment 417830 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=417830&action=review > Source/WebCore/dom/Document.cpp:-760 > -#endif I removed that code that seems not needed given audio producers (media element, audio context) are stopped as active dom objects. Am I missing some cases?
Eric Carlson
Comment 6 2021-01-19 11:51:41 PST
Comment on attachment 417830 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=417830&action=review > Source/WebCore/page/Page.cpp:2121 > + return identifier ? makeObjectIdentifier<MediaSessionGroupIdentifierType>(identifier->toUInt64()) : MediaSessionGroupIdentifier { }; This will be called frequently, would it be worth caching the identifier in a member variable?
youenn fablet
Comment 7 2021-01-20 00:49:52 PST
Created attachment 417948 [details] Patch for landing
youenn fablet
Comment 8 2021-01-20 01:05:27 PST
Created attachment 417949 [details] Patch for landing
youenn fablet
Comment 9 2021-01-20 01:08:33 PST
(In reply to Eric Carlson from comment #6) > Comment on attachment 417830 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=417830&action=review > > > Source/WebCore/page/Page.cpp:2121 > > + return identifier ? makeObjectIdentifier<MediaSessionGroupIdentifierType>(identifier->toUInt64()) : MediaSessionGroupIdentifier { }; > > This will be called frequently, would it be worth caching the identifier in > a member variable? Done
EWS
Comment 10 2021-01-20 02:44:05 PST
Committed r271643: <https://trac.webkit.org/changeset/271643> All reviewed patches have been landed. Closing bug and clearing flags on attachment 417949 [details].
Radar WebKit Bug Importer
Comment 11 2021-01-20 02:45:14 PST
<rdar://problem/73397046>
Note You need to log in before you can comment on or make changes to this bug.