Bug 220695

Summary: [JSC] FTL OSR entry FlushFormat array is reversed
Product: WebKit Reporter: Yusuke Suzuki <ysuzuki>
Component: New BugsAssignee: Yusuke Suzuki <ysuzuki>
Status: RESOLVED FIXED    
Severity: Normal CC: ews-watchlist, keith_miller, mark.lam, msaboff, saam, tzagallo, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch mark.lam: review+

Description Yusuke Suzuki 2021-01-17 21:13:33 PST
[JSC] FTL OSR entry FlushFormat array is reversed
Comment 1 Yusuke Suzuki 2021-01-17 21:14:54 PST
Created attachment 417791 [details]
Patch
Comment 2 Yusuke Suzuki 2021-01-17 21:14:57 PST
<rdar://problem/72930932>
Comment 3 Mark Lam 2021-01-17 22:19:18 PST
Comment on attachment 417791 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=417791&action=review

r=me with suggested comment change.

> Source/JavaScriptCore/ChangeLog:9
> +        After r268783, FTL OSR entry FlushFormat array is reversed wrongly.

I think you meant to say "FlushFormat array is erroneously sorted in reversed order".
Comment 4 Yusuke Suzuki 2021-01-17 23:09:34 PST
Comment on attachment 417791 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=417791&action=review

>> Source/JavaScriptCore/ChangeLog:9
>> +        After r268783, FTL OSR entry FlushFormat array is reversed wrongly.
> 
> I think you meant to say "FlushFormat array is erroneously sorted in reversed order".

Fixed.
Comment 5 Yusuke Suzuki 2021-01-17 23:16:11 PST
Committed r271571: <https://trac.webkit.org/changeset/271571>