Bug 220672

Summary: Apple Mail AX, VoiceOver: When composing a new email message, moving VO focus to the message body field does not bring keyboard focus along.
Product: WebKit Reporter: Andres Gonzalez <andresg_22>
Component: New BugsAssignee: Andres Gonzalez <andresg_22>
Status: RESOLVED FIXED    
Severity: Normal CC: aboxhall, apinheiro, cfleizach, darin, dmazzoni, ews-watchlist, jcraig, jdiggs, samuel_white
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Description Andres Gonzalez 2021-01-15 14:06:26 PST
Apple Mail AX, VoiceOver: When composing a new email message, moving VO focus to the message body field does not bring keyboard focus along.
Comment 1 Andres Gonzalez 2021-01-15 14:12:21 PST
<rdar://problem/73045466>
Comment 2 Andres Gonzalez 2021-01-15 14:23:12 PST
Created attachment 417739 [details]
Patch
Comment 3 Darin Adler 2021-01-15 15:11:05 PST
Comment on attachment 417739 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=417739&action=review

> Source/WebCore/ChangeLog:10
> +        The call to AccessibilityObject::setFocused to set the focus to the
> +        scroll view needs to happen before the check for canSetFocusAttribute.

Normally we require a regression test when we fix a bug. Is there a way to fix this?
Comment 4 Darin Adler 2021-01-15 15:26:03 PST
Comment on attachment 417739 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=417739&action=review

>> Source/WebCore/ChangeLog:10
>> +        scroll view needs to happen before the check for canSetFocusAttribute.
> 
> Normally we require a regression test when we fix a bug. Is there a way to fix this?

I meant to say, "Is there way to make a regression test for this?"
Comment 5 Andres Gonzalez 2021-01-18 14:21:02 PST
(In reply to Darin Adler from comment #4)
> Comment on attachment 417739 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=417739&action=review
> 
> >> Source/WebCore/ChangeLog:10
> >> +        scroll view needs to happen before the check for canSetFocusAttribute.
> > 
> > Normally we require a regression test when we fix a bug. Is there a way to fix this?
> 
> I meant to say, "Is there way to make a regression test for this?"

So far I haven't found any example of a LayoutTest that mimics switching focus to a web view from another view. I don't know if it is possible in the context of LayoutTests.
Comment 6 EWS 2021-01-18 16:03:52 PST
Committed r271589: <https://trac.webkit.org/changeset/271589>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 417739 [details].