Bug 220654

Summary: [GStreamer][Playbin3] Support for CEA-608 closed captioned media
Product: WebKit Reporter: Philippe Normand <pnormand>
Component: PlatformAssignee: Philippe Normand <pnormand>
Status: RESOLVED FIXED    
Severity: Normal CC: calvaris, cgarcia, eric.carlson, ews-watchlist, glenn, gustavo, jenner, jer.noble, menard, philipj, sergio, vjaquez, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 220418    
Bug Blocks:    
Attachments:
Description Flags
Patch calvaris: review+

Philippe Normand
Reported 2021-01-15 03:54:21 PST
.
Attachments
Patch (14.75 KB, patch)
2021-01-27 07:28 PST, Philippe Normand 		calvaris: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Philippe Normand
Comment 1 2021-01-27 07:28:18 PST
Created attachment 418546 [details] Patch
Xabier Rodríguez Calvar
Comment 2 2021-01-28 01:35:17 PST
Comment on attachment 418546 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=418546&action=review > Source/WebCore/platform/graphics/gstreamer/TextCombinerGStreamer.cpp:93 > + WTFLogAlways("GStreamer closedcaption plugins are missing. Please install gst-plugins-bad and gst-plugins-rs"); I would GST_ERROR on this as well, but up to you.
Philippe Normand
Comment 3 2021-01-28 09:23:12 PST
(In reply to Xabier Rodríguez Calvar from comment #2) > Comment on attachment 418546 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=418546&action=review > > > Source/WebCore/platform/graphics/gstreamer/TextCombinerGStreamer.cpp:93 > > + WTFLogAlways("GStreamer closedcaption plugins are missing. Please install gst-plugins-bad and gst-plugins-rs"); > > I would GST_ERROR on this as well, but up to you. Well the whole pipeline would fail in this case anyway due to the unlinked pad. I'm not sure another GST_ERROR is needed :)
Philippe Normand
Comment 4 2021-01-29 02:37:03 PST
Committed r272055: <https://trac.webkit.org/changeset/272055>
Radar WebKit Bug Importer
Comment 5 2021-01-29 02:38:26 PST
<rdar://problem/73747252>
Robert Jenner
Comment 6 2021-02-12 11:50:16 PST
It appears that this revision has broken then test in macOS and iOS: media/track/track-in-band-style.html Bug created: https://bugs.webkit.org/show_bug.cgi?id=221835
Robert Jenner
Comment 7 2021-02-12 11:59:36 PST
Jer has informed us, that this is a rebaseline. We are going to rebaseline with: https://bugs.webkit.org/show_bug.cgi?id=221835
Note You need to log in before you can comment on or make changes to this bug.