Bug 220643

Summary: Web Inspector: Sources: editing a breakpoint action to cause the CodeMirror to wrap doesn't update the `WI.Popover` size
Product: WebKit Reporter: Devin Rousso <hi>
Component: Web InspectorAssignee: Devin Rousso <hi>
Status: RESOLVED FIXED    
Severity: Normal CC: hi, inspector-bugzilla-changes, nvasilyev, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
[Image] screenshot of issue
none
[Video] Bug none

Devin Rousso
Reported 2021-01-14 17:14:35 PST
Created attachment 417670 [details] [Image] screenshot of issue # STEPS TO REPRODUCE 1. inspect any page 2. create a breakpoint 3. add an Evaluate JavaScript action 4. type in the CodeMirror input until the code wraps # EXPECTED the `WI.Popover` would adjust its size to accommodate the new space taken up by the wrapped code # ACTUAL the `WI.Popover` doesn't adjust # NOTES this is not an issue when adding an actual new line
Attachments
[Image] screenshot of issue (79.25 KB, image/png)
2021-01-14 17:14 PST, Devin Rousso 		no flags
Details
[Video] Bug (4.78 MB, video/quicktime)
2021-01-21 14:40 PST, Nikita Vasilyev 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2021-01-14 17:14:46 PST
<rdar://problem/73225206>
Nikita Vasilyev
Comment 2 2021-01-21 14:40:41 PST
Created attachment 418088 [details] [Video] Bug I bisected up to 12 months back and I couldn't find a build that resizes the popover on line wrap. Video of a bug attached.
Devin Rousso
Comment 3 2022-05-27 12:50:07 PDT
Pull request: https://github.com/WebKit/WebKit/pull/1112
EWS
Comment 4 2022-05-27 16:55:45 PDT
Committed r294968 (251072@main): <https://commits.webkit.org/251072@main> Reviewed commits have been landed. Closing PR #1112 and removing active labels.
Note You need to log in before you can comment on or make changes to this bug.