Bug 220577

Summary: Defer setting up app highlight menus until needed to not delay launch time.
Product: WebKit Reporter: Megan Gardner <megan_gardner>
Component: New BugsAssignee: Megan Gardner <megan_gardner>
Status: RESOLVED FIXED    
Severity: Normal CC: thorton, webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch for landing none

Megan Gardner
Reported 2021-01-12 21:25:49 PST
Defer setting up app highlight menus until needed to not delay launch time.
Attachments
Patch (4.25 KB, patch)
2021-01-12 21:36 PST, Megan Gardner 		no flags
DetailsFormatted DiffDiff
Patch (3.81 KB, patch)
2021-01-13 08:59 PST, Megan Gardner 		no flags
DetailsFormatted DiffDiff
Patch for landing (3.84 KB, patch)
2021-01-13 10:25 PST, Megan Gardner 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Megan Gardner
Comment 1 2021-01-12 21:36:50 PST
Created attachment 417507 [details] Patch
Tim Horton
Comment 2 2021-01-12 22:52:34 PST
Comment on attachment 417507 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=417507&action=review > Source/WebKit/UIProcess/ios/WKContentView.mm:625 > + _hasSetUpAppHighlightMenus = NO; Do we need to do this? It doesn't seem like we would need to set them back up when the web process crashes, since they have no web process state associated with them.
Megan Gardner
Comment 3 2021-01-13 08:59:33 PST
Created attachment 417540 [details] Patch
Tim Horton
Comment 4 2021-01-13 09:21:17 PST
Comment on attachment 417540 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=417540&action=review > Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:-846 > - [self setupAppHighlightMenus]; setup or setUp? Please pick one, not both.
Megan Gardner
Comment 5 2021-01-13 10:25:28 PST
Created attachment 417546 [details] Patch for landing
EWS
Comment 6 2021-01-13 11:05:49 PST
Committed r271445: <https://trac.webkit.org/changeset/271445> All reviewed patches have been landed. Closing bug and clearing flags on attachment 417546 [details].
Radar WebKit Bug Importer
Comment 7 2021-01-13 11:06:17 PST
<rdar://problem/73158517>
Megan Gardner
Comment 8 2021-01-13 12:38:35 PST
rdar://72940219
Note You need to log in before you can comment on or make changes to this bug.