| Summary: | Defer setting up app highlight menus until needed to not delay launch time. | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Megan Gardner <megan_gardner> | ||||||||
| Component: | New Bugs | Assignee: | Megan Gardner <megan_gardner> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | thorton, webkit-bug-importer, wenson_hsieh | ||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||
| Version: | WebKit Nightly Build | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Megan Gardner
2021-01-12 21:25:49 PST
Created attachment 417507 [details]
Patch
Comment on attachment 417507 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=417507&action=review > Source/WebKit/UIProcess/ios/WKContentView.mm:625 > + _hasSetUpAppHighlightMenus = NO; Do we need to do this? It doesn't seem like we would need to set them back up when the web process crashes, since they have no web process state associated with them. Created attachment 417540 [details]
Patch
Comment on attachment 417540 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=417540&action=review > Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:-846 > - [self setupAppHighlightMenus]; setup or setUp? Please pick one, not both. Created attachment 417546 [details]
Patch for landing
Committed r271445: <https://trac.webkit.org/changeset/271445> All reviewed patches have been landed. Closing bug and clearing flags on attachment 417546 [details]. |