Bug 220562

Summary: [webkitscmpy] Add GitHub credentials
Product: WebKit Reporter: Jonathan Bedard <jbedard>
Component: Tools / TestsAssignee: Jonathan Bedard <jbedard>
Status: RESOLVED FIXED    
Severity: Normal CC: aakash_jain, dewei_zhu, ews-watchlist, glenn, slewis, webkit-bug-importer, yurys
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=220671
Attachments:
Description Flags
Patch
none
Patch for landing
none
Patch
none
Patch for landing
none
Patch none

Jonathan Bedard
Reported 2021-01-12 13:32:52 PST
The GitHub API has limitations without credentials. In many cases, this is fine, but we're going to need credentialed API access to manipulate pull-requests.
Attachments
Patch (10.72 KB, patch)
2021-01-12 13:37 PST, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
Patch for landing (11.14 KB, patch)
2021-01-14 15:59 PST, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
Patch (1.19 KB, patch)
2021-01-17 21:56 PST, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
Patch for landing (1.19 KB, patch)
2021-01-17 21:57 PST, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
Patch (1.32 KB, patch)
2021-01-22 16:28 PST, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2021-01-12 13:33:04 PST
<rdar://problem/73063457>
Jonathan Bedard
Comment 2 2021-01-12 13:37:36 PST
Created attachment 417486 [details] Patch
dewei_zhu
Comment 3 2021-01-14 15:39:47 PST
Comment on attachment 417486 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=417486&action=review > Tools/Scripts/libraries/webkitscmpy/webkitscmpy/remote/git_hub.py:118 > + username, access_token = self.credentials(required=True if authenticated else False) required=bool(authenticated) ?
dewei_zhu
Comment 4 2021-01-14 15:40:01 PST
r=me
Jonathan Bedard
Comment 5 2021-01-14 15:59:46 PST
Created attachment 417664 [details] Patch for landing
EWS
Comment 6 2021-01-14 16:58:06 PST
Committed r271506: <https://trac.webkit.org/changeset/271506> All reviewed patches have been landed. Closing bug and clearing flags on attachment 417664 [details].
Jonathan Bedard
Comment 7 2021-01-17 21:56:29 PST
Reopening to attach new patch.
Jonathan Bedard
Comment 8 2021-01-17 21:56:30 PST
Created attachment 417795 [details] Patch
Jonathan Bedard
Comment 9 2021-01-17 21:57:28 PST
Created attachment 417797 [details] Patch for landing
Jonathan Bedard
Comment 10 2021-01-17 21:58:21 PST
(In reply to Jonathan Bedard from comment #9) > Created attachment 417797 [details] > Patch for landing keyring needs to be in the autoinstall mapping for webkitpy.
EWS
Comment 11 2021-01-17 22:25:22 PST
Committed r271569: <https://trac.webkit.org/changeset/271569> All reviewed patches have been landed. Closing bug and clearing flags on attachment 417797 [details].
Jonathan Bedard
Comment 13 2021-01-22 16:28:01 PST
Created attachment 418198 [details] Patch
Jonathan Bedard
Comment 14 2021-01-22 16:29:02 PST
(In reply to Yury Semikhatsky from comment #12) > Looks like it broke Ubuntu 18.04 WPE build[1]. xmltodict version is > hardcoded to 0.12.0 but ubuntu 18 has only 0.11.0. > > > [1] > https://build.webkit.org/builders/WPE-Linux-64bit-Release-Packaging-Nightly- > Ubuntu1804/builds/150/steps/generate-minibrowser-bundle/logs/stdio > > [2] > https://github.com/WebKit/WebKit/blob/ > 3b144366ff153f35e1cb334c0fe5f46bb4f216cd/Tools/Scripts/libraries/webkitscmpy/ > webkitscmpy/__init__.py#L55 Uploading a change that uses xmltodict 0.11.0
EWS
Comment 15 2021-01-22 17:22:45 PST
Committed r271768: <https://trac.webkit.org/changeset/271768> All reviewed patches have been landed. Closing bug and clearing flags on attachment 418198 [details].
Note You need to log in before you can comment on or make changes to this bug.