Bug 220562

Summary:

[webkitscmpy] Add GitHub credentials

Product:

WebKit

Reporter:

Jonathan Bedard <jbedard>

Component:

Tools / Tests

Assignee:

Jonathan Bedard <jbedard>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

aakash_jain, dewei_zhu, ews-watchlist, glenn, slewis, webkit-bug-importer, yurys

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

See Also:

https://bugs.webkit.org/show_bug.cgi?id=220671

Attachments:

Description	Flags
Patch	none
Patch for landing	none
Patch	none
Patch for landing	none
Patch	none

Description Jonathan Bedard 2021-01-12 13:32:52 PST

The GitHub API has limitations without credentials. In many cases, this is fine, but we're going to need credentialed API access to manipulate pull-requests.

Comment 1 Radar WebKit Bug Importer 2021-01-12 13:33:04 PST

<rdar://problem/73063457>

Comment 2 Jonathan Bedard 2021-01-12 13:37:36 PST

Created attachment 417486 [details]
Patch

Comment 3 dewei_zhu 2021-01-14 15:39:47 PST

Comment on attachment 417486 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=417486&action=review

> Tools/Scripts/libraries/webkitscmpy/webkitscmpy/remote/git_hub.py:118
> +        username, access_token = self.credentials(required=True if authenticated else False)

required=bool(authenticated) ?

Comment 4 dewei_zhu 2021-01-14 15:40:01 PST

r=me

Comment 5 Jonathan Bedard 2021-01-14 15:59:46 PST

Created attachment 417664 [details]
Patch for landing

Comment 6 EWS 2021-01-14 16:58:06 PST

Committed r271506: <https://trac.webkit.org/changeset/271506>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 417664 [details].

Comment 7 Jonathan Bedard 2021-01-17 21:56:29 PST

Reopening to attach new patch.

Comment 8 Jonathan Bedard 2021-01-17 21:56:30 PST

Created attachment 417795 [details]
Patch

Comment 9 Jonathan Bedard 2021-01-17 21:57:28 PST

Created attachment 417797 [details]
Patch for landing

Comment 10 Jonathan Bedard 2021-01-17 21:58:21 PST

(In reply to Jonathan Bedard from comment #9)
> Created attachment 417797 [details]
> Patch for landing

keyring needs to be in the autoinstall mapping for webkitpy.

Comment 11 EWS 2021-01-17 22:25:22 PST

Committed r271569: <https://trac.webkit.org/changeset/271569>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 417797 [details].

Comment 12 Yury Semikhatsky 2021-01-22 16:15:04 PST

Looks like it broke Ubuntu 18.04 WPE build[1]. xmltodict version is hardcoded to 0.12.0 but ubuntu 18 has only 0.11.0.


[1] https://build.webkit.org/builders/WPE-Linux-64bit-Release-Packaging-Nightly-Ubuntu1804/builds/150/steps/generate-minibrowser-bundle/logs/stdio

[2] https://github.com/WebKit/WebKit/blob/3b144366ff153f35e1cb334c0fe5f46bb4f216cd/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/__init__.py#L55

Comment 13 Jonathan Bedard 2021-01-22 16:28:01 PST

Created attachment 418198 [details]
Patch

Comment 14 Jonathan Bedard 2021-01-22 16:29:02 PST

(In reply to Yury Semikhatsky from comment #12)
> Looks like it broke Ubuntu 18.04 WPE build[1]. xmltodict version is
> hardcoded to 0.12.0 but ubuntu 18 has only 0.11.0.
> 
> 
> [1]
> https://build.webkit.org/builders/WPE-Linux-64bit-Release-Packaging-Nightly-
> Ubuntu1804/builds/150/steps/generate-minibrowser-bundle/logs/stdio
> 
> [2]
> https://github.com/WebKit/WebKit/blob/
> 3b144366ff153f35e1cb334c0fe5f46bb4f216cd/Tools/Scripts/libraries/webkitscmpy/
> webkitscmpy/__init__.py#L55

Uploading a change that uses xmltodict 0.11.0

Comment 15 EWS 2021-01-22 17:22:45 PST

Committed r271768: <https://trac.webkit.org/changeset/271768>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 418198 [details].