Bug 220550

Summary: REGRESSION (r267571): black line appears upon navigating back from apple.com shopping bag
Product: WebKit Reporter: Antoine Quint <graouts>
Component: AnimationsAssignee: Antoine Quint <graouts>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, cmarcelo, dino, esprehn+autocc, ews-watchlist, kangil.han, koivisto, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Safari Technology Preview   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=216931
Attachments:
Description Flags
Patch
none
Patch koivisto: review+

Description Antoine Quint 2021-01-12 10:44:08 PST 
Steps to reproduce on iOS:

1. Open Safari
2. Navigate to apple.com
3. Tap on the shopping bag icon in the top right
4. Tap on the Bag item in the list
5. Wait for the next page to load
6. Navigate back to the previous page

At this point you'll notice a black line appearing in the menu. Prior to r267571, there wouldn't be one.
Comment 1 Antoine Quint 2021-01-12 10:44:23 PST 
<rdar://problem/72459816>
Comment 2 Antoine Quint 2021-01-12 11:03:28 PST 
Created attachment 417472 [details]
Patch
Comment 3 Antoine Quint 2021-01-12 12:13:55 PST 
Created attachment 417476 [details]
Patch
Comment 4 Antti Koivisto 2021-01-13 01:43:58 PST 
Comment on attachment 417476 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=417476&action=review

Looks good

> Source/WebCore/dom/Element.cpp:3320
> +    if (pseudoId == PseudoId::None) {

I'd reverse the test so the main body of the function is the usual None case.
Comment 5 Antoine Quint 2021-01-13 02:11:35 PST 
Committed r271435: <https://trac.webkit.org/changeset/271435>