Bug 220527
| Summary: | fast/hidpi and svg/filters/hidpi don't run in hidpi mode | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Simon Fraser (smfr) <simon.fraser> |
| Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> |
| Status: | REOPENED | ||
| Severity: | Normal | CC: | ap, ryanhaddad, simon.fraser, webkit-bug-importer, zalan |
| Priority: | P2 | Keywords: | InRadar |
| Version: | Safari Technology Preview | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Simon Fraser (smfr)
Testing code does:
static std::optional<double> overrideDeviceScaleFactorForTest(const std::string& pathOrURL)
{
if (pathContains(pathOrURL, "/hidpi-3x-"))
return 3;
if (pathContains(pathOrURL, "/hidpi-"))
return 2;
return std::nullopt;
}
but those directories don't match.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Alexey Proskuryakov
As far as I can tell, this has always been the case. At least some of those tests use testRunner.setBackingScaleFactor.
Note that even though the quoted code is from TestRunnerShared, DumpRenderTree has a copy of this logic.
Radar WebKit Bug Importer
<rdar://problem/73331633>
Alexey Proskuryakov
I'll say "behaves correctly", please feel free to reopen if you disagree.
Simon Fraser (smfr)
There are tests in those directories that are obviously written with the assumption that they are running in hidpi, so something needs to change.