Bug 220516

Summary: AX: Implement aria-braillelabel and aria-brailleroledescription
Product: WebKit Reporter: James Craig <jcraig>
Component: AccessibilityAssignee: chris fleizach <cfleizach>
Status: RESOLVED FIXED    
Severity: Normal CC: aboxhall, andresg_22, apinheiro, cdumez, cfleizach, changseok, dmazzoni, esprehn+autocc, ews-watchlist, gyuyoung.kim, jdiggs, samuel_white, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
See Also: https://bugs.webkit.org/show_bug.cgi?id=220719
Attachments:
Description Flags
patch
none
patch
ews-feeder: commit-queue-
patch none

Attachments
patch (10.76 KB, patch)
2021-01-11 15:37 PST, chris fleizach 		no flags
DetailsFormatted DiffDiff
patch (11.84 KB, patch)
2021-01-12 09:28 PST, chris fleizach 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
patch (12.25 KB, patch)
2021-01-12 09:41 PST, chris fleizach 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2021-01-11 10:48:37 PST
<rdar://problem/73004715>
chris fleizach
Comment 2 2021-01-11 15:37:44 PST
Created attachment 417416 [details] patch
Andres Gonzalez
Comment 3 2021-01-11 18:30:23 PST
(In reply to chris fleizach from comment #2) > Created attachment 417416 [details] > patch diff --git a/Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.cpp b/Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.cpp index 50ce8b6af26b..1a991833828f 100644 --- a/Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.cpp +++ b/Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.cpp @@ -237,0 +238,2 @@ void AXIsolatedObject::initializeAttributeData(AXCoreObject& object, bool isRoot + setProperty(AXPropertyName::BrailleRoleDescription, object.brailleRoleDescription()); + setProperty(AXPropertyName::BrailleLabel, object.brailleLabel()); isolatedCopy() both Strings.
Andres Gonzalez
Comment 4 2021-01-11 18:31:50 PST
The test can be moved as is to LayoutTests/accessibility so that it runs in both MacOS and iOS. We would have to exclude it from GTK and Win.
chris fleizach
Comment 5 2021-01-12 09:28:03 PST
Created attachment 417462 [details] patch Addressed comments, Andres
chris fleizach
Comment 6 2021-01-12 09:41:23 PST
Created attachment 417465 [details] patch
EWS
Comment 7 2021-01-12 14:13:32 PST
Committed r271416: <https://trac.webkit.org/changeset/271416> All reviewed patches have been landed. Closing bug and clearing flags on attachment 417465 [details].
Note You need to log in before you can comment on or make changes to this bug.