Summary: | AX: Implement aria-braillelabel and aria-brailleroledescription | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | James Craig <jcraig> | ||||||||
Component: | Accessibility | Assignee: | chris fleizach <cfleizach> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | aboxhall, andresg_22, apinheiro, cdumez, cfleizach, changseok, dmazzoni, esprehn+autocc, ews-watchlist, gyuyoung.kim, jdiggs, samuel_white, webkit-bug-importer, zalan | ||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||
Version: | WebKit Nightly Build | ||||||||||
Hardware: | All | ||||||||||
OS: | All | ||||||||||
See Also: | https://bugs.webkit.org/show_bug.cgi?id=220719 | ||||||||||
Attachments: |
|
Description
James Craig
2021-01-11 10:48:27 PST
Created attachment 417416 [details]
patch
(In reply to chris fleizach from comment #2) > Created attachment 417416 [details] > patch diff --git a/Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.cpp b/Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.cpp index 50ce8b6af26b..1a991833828f 100644 --- a/Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.cpp +++ b/Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.cpp @@ -237,0 +238,2 @@ void AXIsolatedObject::initializeAttributeData(AXCoreObject& object, bool isRoot + setProperty(AXPropertyName::BrailleRoleDescription, object.brailleRoleDescription()); + setProperty(AXPropertyName::BrailleLabel, object.brailleLabel()); isolatedCopy() both Strings. The test can be moved as is to LayoutTests/accessibility so that it runs in both MacOS and iOS. We would have to exclude it from GTK and Win. Created attachment 417462 [details]
patch
Addressed comments, Andres
Created attachment 417465 [details]
patch
Committed r271416: <https://trac.webkit.org/changeset/271416> All reviewed patches have been landed. Closing bug and clearing flags on attachment 417465 [details]. |