Bug 220459

Summary:

Support unprefixed :autofill pseudo-class.

Product:

WebKit

Reporter:

Emilio Cobos Álvarez (:emilio) <emilio>

Component:

CSS

Assignee:

Emilio Cobos Álvarez (:emilio) <emilio>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

allan.jensen, clopez, cyb.ai.815, emilio, esprehn+autocc, ews-watchlist, glenn, gyuyoung.kim, koivisto, macpherson, menard, ntim, simon.fraser, webkit-bug-importer, youennf

Priority:

Keywords:

InRadar, WebExposed

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

225851

Bug Blocks:

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch for landing	none

Emilio Cobos Álvarez (:emilio)

Reported 2021-01-08 02:39:13 PST

See https://github.com/whatwg/html/issues/6181 / https://github.com/w3c/csswg-drafts/issues/5775

Attachments
Patch (2.23 KB, patch) 2021-05-16 02:34 PDT, Emilio Cobos Álvarez (:emilio)	no flags	Details Formatted Diff Diff
Patch (3.53 KB, patch) 2021-05-16 03:08 PDT, Emilio Cobos Álvarez (:emilio)	no flags	Details Formatted Diff Diff
Patch (11.93 KB, patch) 2021-06-08 12:18 PDT, Emilio Cobos Álvarez (:emilio)	no flags	Details Formatted Diff Diff
Patch (3.52 KB, patch) 2021-06-24 08:12 PDT, Emilio Cobos Álvarez (:emilio)	no flags	Details Formatted Diff Diff
Patch (5.12 KB, patch) 2021-06-24 16:44 PDT, Emilio Cobos Álvarez (:emilio)	no flags	Details Formatted Diff Diff
Patch (6.79 KB, patch) 2021-06-24 17:27 PDT, Emilio Cobos Álvarez (:emilio)	no flags	Details Formatted Diff Diff
Patch for landing (7.65 KB, patch) 2021-07-01 00:49 PDT, Emilio Cobos Álvarez (:emilio)	no flags	Details Formatted Diff Diff
Show Obsolete (6) View All Add attachment proposed patch, testcase, etc.

Radar WebKit Bug Importer

Comment 1 2021-01-15 02:40:13 PST

<rdar://problem/73242004>

Emilio Cobos Álvarez (:emilio)

Comment 2 2021-05-16 02:34:15 PDT

Created attachment 428780 [details] Patch

Emilio Cobos Álvarez (:emilio)

Comment 3 2021-05-16 02:35:42 PDT

Does anybody know what's the issue I hit when importing the tests? Should I file a bug for that? I of course confirmed my patch passes http://wpt.live/html/semantics/selectors/pseudo-classes/autofill.html, but...

Emilio Cobos Álvarez (:emilio)

Comment 4 2021-05-16 02:56:12 PDT

Err, forgot the -t flag, and it was defaulting to a super-old revision. Will fix.

Emilio Cobos Álvarez (:emilio)

Comment 5 2021-05-16 03:08:08 PDT

Created attachment 428782 [details] Patch

Emilio Cobos Álvarez (:emilio)

Comment 6 2021-06-08 12:18:34 PDT

Created attachment 430872 [details] Patch

Emilio Cobos Álvarez (:emilio)

Comment 7 2021-06-08 12:21:37 PDT

Comment on attachment 430872 [details] Patch Err, webkit-patch got confused when not submitting HEAD, looks like... This should've gone to the dependent bug.

Emilio Cobos Álvarez (:emilio)

Comment 8 2021-06-24 08:12:09 PDT

Created attachment 432164 [details] Patch

Emilio Cobos Álvarez (:emilio)

Comment 9 2021-06-24 16:44:37 PDT

Created attachment 432221 [details] Patch

Emilio Cobos Álvarez (:emilio)

Comment 10 2021-06-24 17:27:39 PDT

Created attachment 432224 [details] Patch

Emilio Cobos Álvarez (:emilio)

Comment 11 2021-06-24 21:56:16 PDT

Alright, ews is green now.

Tim Nguyen (:ntim)

Comment 12 2021-06-30 03:00:45 PDT

Small nit: I think some changelogs need to be regenerated

Emilio Cobos Álvarez (:emilio)

Comment 13 2021-07-01 00:49:34 PDT

Created attachment 432664 [details] Patch for landing

EWS

Comment 14 2021-07-01 02:03:47 PDT

Committed r279457 (239313@main): <https://commits.webkit.org/239313@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 432664 [details].

Note You need to log in before you can comment on or make changes to this bug.