Bug 220449

Summary:

JavaScriptCore API headers contain project style includes

Product:

WebKit

Reporter:

Alexey Proskuryakov <ap>

Component:

JavaScriptCore

Assignee:

Alexey Proskuryakov <ap>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

ews-watchlist, keith_miller, mark.lam, msaboff, rmorisset, saam, tzagallo, webkit-bug-importer, ysuzuki

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
proposed patch	none

Description Alexey Proskuryakov 2021-01-07 17:39:48 PST

Maybe I'm missing some reason for it, but it seems wrong for framework headers to use project style includes.

rdar://problem/71493605

Comment 1 Alexey Proskuryakov 2021-01-07 17:45:56 PST

Created attachment 417234 [details]
proposed patch

Comment 2 Alexey Proskuryakov 2021-01-07 17:47:35 PST

There are also lots of SPI headers, where the include style is wrong too, but that's a cleanup for another day.

Comment 3 Yusuke Suzuki 2021-01-08 10:39:05 PST

Comment on attachment 417234 [details]
proposed patch

r=me

Comment 4 EWS 2021-01-08 12:23:12 PST

Committed r271317: <https://trac.webkit.org/changeset/271317>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 417234 [details].